Support for php 7.3

Hello! There are still several PHP7.3 related issues in WP5.0.1: https://core.trac.www.ads-software.com/query?keywords=~php73&col=id&col=summary&col=status&col=owner&col=type&col=priority&col=milestone&order=priority

I have tested the Menu Cart plugin in a clean WP5.0.1 install with WooCommerce 3.5.2 + WooCommerce Menu Cart 2.7.3 and cannot reproduce your issue.The menu cart does not link to the checkout page out of the box (only the cart page for a cart with items, or the shop page for an empty cart), so if you have applied any customizations here, I recommend checking if they are compatible with PHP7.3.

To elimate other factors I recommend testing with a theme that has declared compatibility with PHP7.3 (take twentynineteen to be sure) and with all other plugins (except WooCommerce) disabled. Let us know if you then still have this issue!

I’ve exactly the same problem. The problem only occurs on PHP7.3

Php 7.3 jquery.js?ver=1.12.4:4 POST https://www.xxx.xx ?wc-ajax=update_order_review 500

Could you check your PHP error log for the exact error? A 500 error is a generic frontend message that is usually triggered by an underlying PHP error. Knowing the exact PHP error we can backtrace the root cause. As mentioned above, I have not been able to reproduce this in a clean install with PHP7.3

Hello,

I am still getting 504 Gateway Timeout
The gateway did not receive a timely response from the upstream server or application.
This only appears when I click on the menu cart but other site pages are loading perfectly.

I checked my error log file and I found this I don’t really know what it means.

[24-Dec-2018 11:31:18 UTC] id was called incorrectly. Product properties should not be accessed directly. Backtrace: require(‘wp-blog-header.php’), require_once(‘wp-load.php’), require_once(‘wp-config.php’), require_once(‘wp-settings.php’), do_action(‘wp_loaded’), WP_Hook->do_action, WP_Hook->apply_filters, WC_Cart_Session->get_cart_from_session, WC_Product->is_purchasable, apply_filters(‘woocommerce_is_purchasable’), WP_Hook->apply_filters, sv_disable_repeat_purchase, WC_Abstract_Legacy_Product->__get, wc_doing_it_wrong. This message was added in version 3.0.

Your error is unrelated to the menu cart, it’s an outdated filter in your functions.php (linked to a function named sv_disable_repeat_purchase that needs to be updated for WooCommerce 3+
It appears to be this: https://www.skyverge.com/blog/prevent-repeat-purchase-with-woocommerce/

This only appears when I click on the menu cart but other site pages are loading perfectly.

If you open that same url without the menu cart, you should see the same effect. What you describe sounds like it is not related to the menu cart itself.

Well tried to get a log php file but i couldn’t make it..

I increased my php limit to 256Mb but it still keeps endless loading add the cart or checkout . I’ am back on php 7.2 and all is fine.

/?wc-ajax=update_order_review:1 Failed to load resource: the server responded with a status of 500 ()

https://www.ads-software.com/support/topic/error-after-switching-tot-php-7-3/