Viewing 7 replies - 1 through 7 (of 7 total)
  • Plugin Contributor Michael Beckwith

    (@tw2113)

    The BenchPresser

    Was aware of this, hadn’t implemented yet, and I thought I had a GitHub issue for it already, but this brand new one will have to do https://github.com/WebDevStudios/custom-post-type-ui/issues/133

    No guarantee on time frame, I’m kind of in the middle of a big UI revamp for the CPTUI and need to make sure the plugin still works as expected after upgrades etc.

    Thread Starter Javier Villanueva

    (@vengisss)

    Oh I didn’t know there was a github repo, I can submit a PR to the master branch if that’s ok I assume the UI revamp is on the dev branch.

    Plugin Contributor Michael Beckwith

    (@tw2113)

    The BenchPresser

    Sure, you can submit a pull request on the master branch. I probably won’t *properly* accept it, simply because of how much I’m breaking up the main file into separate files, but it’ll help me to know how to add the support later on once pieces are back into place. However, do not worry as I’d still give you proper credit for contributing. Hope you’re cool with that.

    Thread Starter Javier Villanueva

    (@vengisss)

    No problem with me, I just sent a PR with the “fix” I’m currently using on my themes but you might want to tweak it a bit further.

    https://github.com/WebDevStudios/custom-post-type-ui/pull/143

    Plugin Contributor Michael Beckwith

    (@tw2113)

    The BenchPresser

    I saw. Thanks for this. From the looks of the pull request, it’s simply a case of changing the esc_* sanitation, which won’t be hard to add to my dev branch at all. Credit still to you!

    Thread Starter Javier Villanueva

    (@vengisss)

    Great looking forward to the new version!

    Plugin Contributor Michael Beckwith

    (@tw2113)

    The BenchPresser

    It probably won’t be for a little while yet, lots going on. However, I am planning to call for beta testers at that time. I will need as many people with dev environments + real use, to test saved option conversion and ensuring things work as expected post-upgrade without hickup.

Viewing 7 replies - 1 through 7 (of 7 total)
  • The topic ‘Support for SVG and dashicons for menu icon’ is closed to new replies.