Viewing 15 replies - 1 through 15 (of 21 total)
  • Hi @mtngeekuk
    Looks like a wp function is getting wrong height and width values for those svg images.
    This will be, most likely, fixed in the next customizr release.
    If you cannot wait, do you feel to make some little changes to a customizr file?

    Thread Starter mtngeekuk

    (@mtngeekuk)

    Hi

    Thanks for the speedy reply – glad it’s not just me!

    Happy to give it a go – can always do CTRL-Z, right?

    Yep ??
    I made a pull-request on github.
    https://github.com/eri-trabiccolo/customizr/commit/9604be2863fd72132a060025ac2d0fe84bb20988

    Can you apply it?
    It’s just about going in that file
    customizr/inc/parts/class-header-header_main.php
    and change those two lines you see in light red according to the other 2 in light green.
    (lines 171,172)

    Let me know if you have any problem.
    Make a backup of that file, so if you make some syntax error you can revert it easily.

    Thread Starter mtngeekuk

    (@mtngeekuk)

    Hi,

    Made the change, but no effect.

    Can you just check I’ve done it correctly?

    Thanks again

    cannot check your files ??
    What I can see is that you show just the title.
    Have you uploaded the files again?

    Look, I’ve downloaded your files and uploaded them in Appearance->Customize bla bla bla.
    This is what I get:
    https://i61.tinypic.com/2mqrhhl.jpg

    Thread Starter mtngeekuk

    (@mtngeekuk)

    Soo annoying – still not having it for me.

    Is my installation of WordPress blocking SVG files or something?

    I’m Self-hosted, if that makes a difference?

    Mmm don’t think so.
    Tried to delete the logos (still) from that panel and reupload them again?
    Let me see your new inc/parts/class-header-header_main.php
    paste it in pastebin and past the link here, please

    Thread Starter mtngeekuk

    (@mtngeekuk)

    Here we go – hope this helps?

    <iframe src="https://pastebin.com/embed_iframe.php?i=Z8jCUkrx" style="border:none;width:100%"></iframe>

    Thread Starter mtngeekuk

    (@mtngeekuk)

    Try that again…

    Thread Starter mtngeekuk

    (@mtngeekuk)

    So you haven’t done anything wrong.
    The thing is that those files aren’t recognized as svg, so the fallback to the title.
    Verify this by yourself:

    add_filter('tc_sticky_logo_src', 'my_logo');
    add_filter('tc_logo_src', 'my_logo');
    function my_logo($logo){
        $normal = 'https://upload.wikimedia.org/wikipedia/commons/2/2c/Download_font_awesome.svg';
        $sticky = 'https://www.mountaingeek.co.uk/wp-content/uploads/2015/01/MountainGeek2015.svg';
        if ( current_filter() == 'tc_logo_src'){
            return $normal;
        }
        return $sticky;
    }

    Add that to your child-theme functions.php.

    The weird think is that when I download that file on my pc, and upload it regularly as logo it works (obviously with the small patch I gave you).
    Weird.. I have to investigate.

    Thread Starter mtngeekuk

    (@mtngeekuk)

    So I add that code block into my child theme functions.php and the whole thing blows up.

    This is what I’ve got in there…

    <?php
    add_filter(‘tc_credits_display’, ‘my_custom_credits’);
    function my_custom_credits(){
    $credits = ‘ ‘;
    $newline_credits = ‘ ‘;
    return ‘
    <div class=”span4 credits”>
    <p> · © ‘.esc_attr( date( ‘Y’ ) ).’ ‘.esc_attr(get_bloginfo()).’ ·</p> </div>’;
    }

    add_filter('tc_sticky_logo_src', 'my_logo');
    add_filter('tc_logo_src', 'my_logo');
    function my_logo($logo){
    $normal = 'https://upload.wikimedia.org/wikipedia/commons/2/2c/Download_font_awesome.svg&#039;;
    $sticky = 'https://www.mountaingeek.co.uk/wp-content/uploads/2015/01/MountainGeek2015.svg&#039;;
    if ( current_filter() == 'tc_logo_src'){
    return $normal;
    }
    return $sticky;
    }

    ?>

    Ok remove it, probably you have left a blank space after ?>. Anwyay don’t close that pure php file with a ?> isn’t needed and may cause this kind of issue.
    That said.
    Apply also this other patch:
    https://github.com/eri-trabiccolo/customizr/commit/a57ec960e77a437d8737a5b44960df084f4f1a79
    just this: $filename = basename( $filename );
    don’t care about this: endif;
    Talk you later.

    Thread Starter mtngeekuk

    (@mtngeekuk)

    It’s ok, have resolved this – internet quotes, rather than “proper” ones.

    So, page loads, but I get a big down arrow, enclosed in a circle – I’m guessing some sort of download image – it’s the same in both Chrome and Firefox, and in Android mobile browser, so not sure what’s going on now?

    Do you get the same, or do you need a screenshot?

Viewing 15 replies - 1 through 15 (of 21 total)
  • The topic ‘SVG images not working’ is closed to new replies.