Syntax issue and can’t configure warehouses

@allanext

I lost track of this plugin development but I will have an update for you shortly with the errors fixed.

I’ll also get the pricing feature implemented for you guys asap.

@allanext the plugin was updated. Should be working now.

@joeleem0n i think the syntax issue is still there, i’ve simply fix it by making a change in the code, see https://www.ads-software.com/support/topic/role-based-pricing-3/)

But there some thing related to php or some coding standard of these hooks; on the configuration of the warehouses by going to woocommerce -> settings -> warehouses there isn’t any configuration displayed, and page displays the straight php code from line 108 of the file /wp-content/plugins/warehouse-popups-woocommerce/admin/class-warehouse-popups-woocommerce-admin.php

by changing:

?>
<a href="admin.php?page=wc-settings&tab=warehouses" class="nav-tab <?php echo $current_tab?>"><?php echo __( "Warehouses", "warehouse-popups-woocommerce" )?></a>
<?

to:
echo "<a href=\"admin.php?page=wc-settings&tab=warehouses\" class=\"nav-tab $current_tab\">Warehouses</a>";

it works!

This seems to be resolved with 1.2.4, thanks @joeleem0n !

• This reply was modified 5 years, 1 month ago by allanext.

This issue just reappeared in version 1.2.6, do I need to update PHP or add some libraries?

Did the same fix as above but now showing warehouses on all the woocommerce settings tabs

• This reply was modified 4 years, 10 months ago by allanext.

ok @joeleem0n, i’m really not sure what is happening but closing and opening those php delimiters tags ( ?> <?php ) is part of the issue, i’ve changed:

?><h2><?php _e( 'Edit Warehouse Details', 'warehouse-popups-woocommerce' );?></h2><?php

to echo('<h2>Edit Warehouse Details</h2>'); as the _e function is only for translation of strings

and the other issue is the opening of the <?php in the abbreviated form, changed:

$current_tab = ( $_GET['tab'] == 'warehouses' ) ? 'nav-tab-active' : '';
		?>
			<a href="admin.php?page=wc-settings&tab=warehouses" class="nav-tab <?php echo $current_tab?>"><?php echo __( "Warehouses", "warehouse-popups-woocommerce" )?></a>
		<?

to:

$current_tab = ( $_GET['tab'] == 'warehouses' ) ? 'nav-tab-active' : '';
		?>
			<a href="admin.php?page=wc-settings&tab=warehouses" class="nav-tab <?php echo $current_tab?>"><?php echo __( "Warehouses", "warehouse-popups-woocommerce" )?></a>
		<?php

my php version:
PHP 7.0.33 (cli) (built: Jan 9 2019 22:04:26) ( NTS )
Copyright (c) 1997-2017 The PHP Group
Zend Engine v3.0.0, Copyright (c) 1998-2017 Zend Technologies

• This reply was modified 4 years, 10 months ago by allanext.

@allanext
my developers just made an update and issued a few fixes. here’s what he sent to me.

“this code is correct, and doesn’t make any warnings on most servers. It could be it’s a server config… need to see the error message they are getting to know what to do next. just replacing code with a code user provider – is not good idea, that code doesn’t make proper texts translations, which is required in order to keep our plugin extendable”

@allanext
this issue was fixed:

“$current_tab = ( $_GET[‘tab’] == ‘warehouses’ ) ? ‘nav-tab-active’ : ”;
?>
“><?php echo __( “Warehouses”, “warehouse-popups-woocommerce” )?>
<?”

Thank you! I’ve just made the plugin update and verified that the issue is fixed