Syntax Warning on PHP 7.3

  • Resolved homullus

    (@homullus)


    6 years, 2 months ago

    Hey guys, your plugin is fucking awesome. Thank you for making it, and publishing it for free. This is the only plugin in the registry that does some honest work.

    So, on PHP7.3 we have an error on line 156 of includes/lib/td-util/class-td-model.php whereby a continue, used within a switch statement will just default to a break. In this case i think you wanted a continue 2; maybe?

    I fixed it manually for now, but the very next update will break it, so it should be fixed upstream ?? thanks!!

Viewing 5 replies - 1 through 5 (of 5 total)
  • Plugin Author NSquared

    (@croixhaug)

    Thank you @homullus for the kind words – and for letting us know about that syntax issue! I’ve fixed it in our upstream, so our next release will have the fix in there.

    If you have a minute to post a quick review, we’d appreciate it. It helps more people find our plugin ??

    Best,
    Nathan

    Thread Starter homullus

    (@homullus)

    Hey, thanks for the response, and fixing the thing. Is the project open source or licenced for now?

    Will rate ofc ??

    Plugin Author NSquared

    (@croixhaug)

    Yep, it’s all GPL (open-source) licensed. We have Plus & Pro versions available with more features, but the core product will always be free ??

    Thanks,
    Nathan

    Thread Starter homullus

    (@homullus)

    Nice, so if it’s open source, i guess you might have a Git-based repo that you use for actual development and tickets, because WP’s system is blah… If so, could i get a link, to look around, maybe i would be interested in solving some tickets or translating or something similar.

    Plugin Author NSquared

    (@croixhaug)

    Hi @homullus, we are set up to allow translation, and are welcoming translations from contributors

    You can see the translation system here:
    https://translate.www.ads-software.com/projects/wp-plugins/simply-schedule-appointments

    For example, we currently have a French translation in progress, and www.ads-software.com has a “Translator Handbook” to help people get started @ https://make.www.ads-software.com/polyglots/handbook/tools/glotpress-translate-wordpress-org/
    ?
    We want Simply Schedule Appointments to be used around the world, and translations are a big part of that. Unfortunately we only know English, so we’d welcome any help you can provide ??
    ?
    ?Our git repository isn’t currently public. We haven’t had time to document the whole build process and local development requirements (we have a bit of a unique setup because of the build process for the VueJS apps for the admin screen and the booking form). We’d like to open that up in the future. In the meantime, if you have any specific patches, you can always send us code changes to [email protected] and we’d be happy to take a look at them.

    Thanks!
    Nathan

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘Syntax Warning on PHP 7.3’ is closed to new replies.