the upgrade broke your plug-in

Hi Dan,

Well, that is certainly not one of the exciting features that was intended to be delivered in 1.1.0! ??

I am terribly sorry that I did not catch that in testing; it appears that this afflicts those who are running a PHP version prior to 5.5.

Please replace line 796 of /post-notif/admin/class-post-notif-admin.php, which currently reads:

if ( ! ( empty( trim( $recipient_email_addr ) ) ) ) {

with this instead:

if ( false != trim( $recipient_email_addr ) ) {

and let me know if that fixes the problem. Great catch, thank you for reporting it!

Thanks much,
Devon

Uh-oh, fixed that, now I get:

Fatal error: Can’t use function return value in write context in /home/smithgeraint/public_html/wp-content/plugins/post-notif/includes/class-post-notif-misc.php on line 202

Thanks for sticking with it!

Hi Dan,

Ah man, there are two more. Please fix the one you found in class-post-notif-misc.php (line 202) AND line 276 in the same file (both of which are the same “if” statement) by replacing this:

if ( empty( trim( $local_timezone ) ) ) {

with this:

if ( false == trim( $local_timezone ) ) {

Please do let me know if this is the last of the fatal errors you get!

Assuming this gets Post Notif back to working for you, I will roll these out in a point release shortly.

Thanks for your help with this,
Devon

The good news is your plug-in is back up and working.

The bad news is I think I’ve lost the 45 or so subscribers I had accumulated.

When the plug-in initially failed, I lost control of my admin panel, and freaked.

I went in via FTP and changed the name of the post notif plugin folder to disable it.

But I think the renamed plugin folder was deleted by wordpress when I tried to install a fresh copy of the plugin.

The big question is, have I lost all my subscribers?

Are they in the database somewhere, or are the gone with the deleted plugin?

Holding my breath,

Thanks,

Dan

• This reply was modified 8 years ago by frankdan.

Hi Dan,

I am glad to hear that those code changes resolved the PHP errors.

As far as subscriber data, that is contained only in the database (not the file system). So as long as you only de-activated the plugin, but did not delete it (via the Plugins page [where it warns you that all data will be deleted if you proceed]) your data should remain. It sounds like you did not de-activate via the Plugins page so I am not sure exactly what happened but the Post Notif custom tables should only be affected by choosing to explicitly delete them from the Plugins page or by manually deleting them via a SQL tool.

I sure hope your subscribers are intact!

Thanks,
Devon

I did delete the plugin, but not before I backed up the database.

After reinstalling the plugin with your fixes and importing the subscribers, all’s well.

Thanks!

Dan

https://geraintsmith.com

Hi Dan,

Thank goodness you took a backup! Again, apologies for putting you through that. I want to thank you again for the quick reporting on the problem and your testing; I really do appreciate it!

Take care,
Devon