Theme Check Errors in Twenty Twelve

  • My theme is a child of Twenty Twelve. I recently installed the Theme Check Plugin to make sure that my theme was passing the latest WP standards. It didn’t. It turns out that part of the reason is that its parent, Twenty Twelve doesn’t: Below is the result of the test: 

    One or more errors were found for Twenty Twelve.

    REQUIRED: The theme must not use the <title> tags.
    REQUIRED: The theme must not call to wp_title().
    REQUIRED: No reference to add_theme_support( "title-tag" ) was found in the theme.
    RECOMMENDED: Screenshot size should be 1200x900, to account for HiDPI displays. Any 4:3 image size is acceptable, but 1200x900 is preferred.
    RECOMMENDED: No reference to add_theme_support( "custom-background", $args ) was found in the theme. If the theme uses background images or solid colors for the background, then it is recommended that the theme implement this functionality.
    INFO: Only one text-domain is being used in this theme. Make sure it matches the theme's slug correctly so that the theme will be compatible with www.ads-software.com language packs.
    The domain found is twentytwelve

    Should I a.) be concerned that Twenty Twelve is suddenly going to be removed from the official WP Themes, b.) not worry because they don’t have anything to do with security?

    Please note that I am not particularly keen to change the parent for my child theme.

    If WP developers are NOT planning an update of twenty twelve to address these issues, I trust there will be a warning (with plenty of lead time) that support for twenty twelve is going to disappear.

    Please advise. Thank you.

    -E Morris, etherwork [dot] net [slash] blog << purposely unlinked in attempt to keep spammers at bay (there’s a really good reason that I have WordFence plugin that helped enormously to rid me of bruteforce attacks….)

    resources for this query:

    The theme check plugin is an easy way to test your theme and make sure it’s up to spec with the latest theme review standards. With it, you can run all the same automated testing tools on your theme that www.ads-software.com uses for theme submissions.

    The tests are run through a simple admin menu and all results are displayed at once. This is very handy for theme developers, or anybody looking to make sure that their theme supports the latest WordPress theme standards and practices.

    [https://www.ads-software.com/plugins/theme-check/]
    __________________________
    [The volunteers on the Theme Review Team] review and approve themes submitted to be included in the official WordPress Theme directory. […] The reviewer does a review by checking the required items and noting any recommendations. […] If all the required items aren’t met, the theme should not be approved and left open in reviewing status for updates.

    [https://make.www.ads-software.com/themes/handbook/review/]

Viewing 13 replies - 1 through 13 (of 13 total)

  • TwentyTwelve is quite old so I doubt it’ll be updated to conform with the current standards in ThemeCheck to meet the requirements. Some of the other “Twenty” themes that ship with WordPress by default don’t pass the theme check either.

    I wouldn’t worry about any changes happening in the future as the theme is old and the warnings mentioned in the test aren’t security related.

    What about SEO issues?

    Thread Starter ejm

    (@llizard)

    Re:

    TwentyTwelve is quite old so I doubt it’ll be updated to conform with the current standards in ThemeCheck to meet the requirements.

    Sigh. It’s not that old. It has only been 7 years since 2012. I do realize that in Computerland, 7 years is eons. But in real life, 7 years is no time at all. Also because TwentyTwelve is an official WP theme put out by WP, I have hopes that it will continue to be supported. It would be nice to hear an official word from someone on the WP development team.

    the warnings mentioned in the test aren’t security related.

    That’s a relief to hear. Thank you for that.

    Thread Starter ejm

    (@llizard)

    I’m really hoping that the fact that TwentyTwelve is not passing the theme-check because of the following does not mean that it is going to be retired.

    REQUIRED: The theme must not use the <title> tags.
REQUIRED: The theme must not call to wp_title().
REQUIRED: No reference to add_theme_support( "title-tag" ) was found in the theme.

    Is this considered to be a “major issue”? Can it be reported?

    Knowing only the bare minimum of php coding, I’m only guessing that it would be a relatively easy fix. Would it not just require an update to the header.php and functions.php in the twentytwelve folder? Or am I being naive?

    Hi,

    I’m really hoping that the fact that TwentyTwelve is not passing the theme-check because of the following does not mean that it is going to be retired.

    As far as I know all the WordPress themes from the Twenty family group are still maintained. You can check the Twenty Twelve changelog link if you like for verification.

    Kind regards

    Thread Starter ejm

    (@llizard)

    re:

    As far as I know all the WordPress themes from the Twenty family group are still maintained.

    In view of that, mbrsolution, do you think it would it be inappropriate to fill out a report on the theme? ie: Are the instructions that the theme must not use <title> tags, call to wp_title(), and the fact that No reference to add_theme_support( "title-tag" ) was found in the theme considered to be “a major issue”?

    Hi, you could create a ticket if you like. I am sure WordPress developers are aware of these requirements. But remember they are not a security risk, they are just a requirement for theme development.

    Kind regards

    Thread Starter ejm

    (@llizard)

    Because they are not a security risk, that indicates to me that this would not be considered to be a “major issue”. I will refrain from creating a ticket.

    I just hope that if the WP developers do decide to stop maintenance on twenty twelve, there will be plenty of warning.

    Hi,

    I just hope that if the WP developers do decide to stop maintenance on twenty twelve, there will be plenty of warning.

    Yes I am sure they would let the community know.

    I am currently using this theme in one of my blogs and I love the simplicity of the theme. I am all for simple designs and not complex designs ??

    Kind regards

    Hi I am using the twenty twelve theme and the following message appears on all pages: [REQ_ERR: 403] [KTrafficClient] Something is wrong. Enable debug mode to see the reason.
    After debugging the following message appears (3 times):
    Notice: Use of undefined constant HTTP_USER_AGENT – assumed ‘HTTP_USER_AGENT’ in /home4/baerliec/public_html/wp-content/themes/twentytwelve/header.php on line 1
    Thanks for any help

    • This reply was modified 5 years, 1 month ago by andrea1960.

    @andrea1960 it could be that your site is hacked, I would suggest reading the article here

    FAQ My site was hacked

    That user agent is definitely not something that comes with the default TwentyTwelve theme

    Hi
    I did the scans and it comes back all clear. Don’t know what to do next

    Hi,

    ive been using this theme since its came out, the problem is my tittle tag for my website is not updating since november, does anybody know how to resolve this asap?

    ive been change my seo plugin from ALL In One SEO pack to Yoast but it still the same

    i have checked to google webmaster tool and its crawled fine (last crawled was in 7 jan 2020), but somehow my tittle tag is still showing “NOVEMBER 2019” not “JANUARY 2020”

    Please help !

Viewing 13 replies - 1 through 13 (of 13 total)
  • The topic ‘Theme Check Errors in Twenty Twelve’ is closed to new replies.