There’s a massive margin bottom on every header since updating.

  • Resolved Alundra

    (@alundra)


    9 months, 3 weeks ago

    h1:where(:last-child),h2:where(:last-child),h3:where(:last-child),h4:where(:last-child),h5:where(:last-child),h6:where(:last-child) {
    margin-bottom: 0
}

:is(.entry-content,.is-layout-flow,.is-layout-constrained)>* {
    /* margin-bottom:var(--theme-content-spacing); */
}

    Hello! Why did you put a margin bottom on all headers? I’m wondering why all my headers are suddenly a billion miles away from all the text since the update and then I discover it’s this…. How did this escape testing? There’s already a ginormous gap between headers and text so I don’t get what you were going for. My last topic was on a similar problem where you guys removed left padding from drop down menus (which thankfully is fixed). I think you guys need more thorough testing on existing designs.

    How do I download an older version? I want this website to go live this week and I can’t do it while it looks like this – it’s a mess on every single page and every single section.

Viewing 15 replies - 16 through 30 (of 30 total)
  • Thread Starter Alundra

    (@alundra)

    Also those are custom classes on your starter sites. If I remove them the design completely changes…..so it’s not using Blocksy’s customiser to change the design globally, it’s relying heavily on custom classes added to the Gutenberg blocks.

    There’s a previous post before this one sorry, it made a new page please check that one too :D.

    • This reply was modified 9 months, 2 weeks ago by Alundra.

    Hello @alundra

    I’m not sure why you’re saying that these have custom CSS. They do not have any custom CSS.

    These sites are not made with standard Gutenberg blocks, but with plugins. These plugins have separate controls which we adjust per our design documents.

    Waiting on that snapshot so that we could diagnose your issue. ??

    Thanks.

    Thread Starter Alundra

    (@alundra)

    Oh that would explain all the excess html and why everything has extra css.

    I couldn’t figure out how to get that plugin to send stuff without also sending passwords and emails (as it’s a full migration it doesn’t just copy the design unfortunately) so I temporarily uploaded a version to my personal website: jades-world dot com slash duffabird (sorry I don’t want it indexed and I don’t know how to add a noindex/nofollow link on here ha ha). The only plugins active are Blocksy Companion and Gutenberg.

    If you hover over about there’s two samples, one each for plain page/blog.

    Hello @alundra

    Ok, I see the problem. But I do have an idea to better verify this.

    Can you copy all blocks from those two pages, paste them in a .txt file and send them to us? You can do so like this – https://ibb.co/hR7vq8N

    Thanks!

    Thread Starter Alundra

    (@alundra)

    Sure but like I said they are literally just plain Gutenberg blocks I changed nothing :). I just wrote what I wanted for title and clicked paragraph and changed to title :D.

    Thanks for looking into it!

    https://pastebin.com/raw/gkekSXfM

    • This reply was modified 9 months, 2 weeks ago by Alundra.

    Hi @alundra

    Sadly, the contents of the file have been modified somehow and I cannot paste them in the editor. Can you please try going the .txt file route? That should be fail-proof.

    I do have an idea of what’s happening here, but I really need to confirm with your exact layout in order to get consistent results/answers.

    Thanks a lot!

    Thread Starter Alundra

    (@alundra)

    There’s no difference. I pasted the new copy and that raw into winmerge and there’s no differences. So it must be on your end :). Make sure you’re using Gutenberg and are in a page not a post I don’t know if that makes a difference. I don’t have other plugins either so make sure you only have Blocksy + companion, and Gutenberg.

    Text file here: https://file.io/poVZQNnFt4SX

    Hello @alundra,

    I can tell you for sure that there was a difference. I could copy paste the blocks correctly now.

    In any case, let’s see about this. Please start by watching this short video – https://streamable.com/7nrcp1.

    Notice that indeed we have spacing added between blocks. But if you look at the second part of the video, you will see that everything here is behaving as expected.

    All other default themes have the same spacing, as to space out these blocks a bit. They wouldn’t look good with no spacing.

    The bonus in Blocksy is that you can remove or adjust it, if you want. To do so, you can go to the Customiser -> General -> Entry Content -> Content Spacing and adjust to whatever you need.

    Hope this clears things up!

    Thanks.

    Thread Starter Alundra

    (@alundra)

    Twenty Twenty balances their spacing for their theme. I am aware that there will always be spacing, that’s not the problem :).

    I’ve set it to Spacious, which means that yes there’s gonna be a huge amount of space there. However this is not the issue. The issue is your formula for the space before most headings.

    Please see this image that highlights that the space is always too much for every setting, even “none” has spacing for some headers which proves that your spacing is inconsistent.

    I don’t think “comfortable” or “compact” are size appropriate either. Compact should be smaller, comfortable should be “compact” and Spacious should be just a little more than comfortable. These look doubled to me.

    I don’t like the other settings they feel squashed but this one is now unbalanced since introducing that formula and frankly the margin at all. The theme felt very spacious before this, now it just feels like giant gaps.

    I just think you need to re-balance. The problem isn’t me or the setting.

    • This reply was modified 9 months, 2 weeks ago by Alundra.

    Hello @alundra

    I have managed to get a Blocksy 1 setup working to compare the spacing with the old version and everything is the same, actually – https://streamable.com/nmypvp.

    The spacing options are some defaults that you may want to take, they’re thought to be a few initial options to get started. If the default options aren’t good for you, you can always change them up with a bit of CSS –

    :root {
    --theme-content-spacing: 2em !important;
}

    Hope this gets us both on the same page. ??

    Thank you.

    Thread Starter Alundra

    (@alundra)

    Hey Eduard!

    So if you look at your stream which is awesome by the way you’ll notice there is a difference ha ha. It’s the original report. In one of those captures the margin is BENEATH the title, in the other it’s ABOVE the title. I reported problems with the margin below and you guys moved it above which causes just as many issues :).

    I think you need to compare these two with with the version before that one, and you’ll see a huge difference. I think that’s Version: 2.0.22 :).

    Hello @alundra,

    Ok, so I have now confirmed that you were testing with 2.0.2x. In reality, those versions were ones with a few problems, as we needed to rework this spacing to accommodate a few Gutenberg plugins. And we’ve released a bunch of small updates to mitigate errors as much as possible in a short time.

    The latest versions (and implicitly 1.9.x) are the ones that are actually good and working correctly. So, if you can please try comparing with 2.0.1x, or 1.9. You will see that there is no difference between these.

    Thanks!

    Thread Starter Alundra

    (@alundra)

    You’ve lost me. I’m on the latest version and this is still an ongoing issue.

    It started with massive margins added BELOW headers on the update right before Feb 5th.

    ….

    Then it went to massive margins ABOVE headings around valentines day.

    I’ve reported these changes with the updates they came with. The video shows both of these issues, it does not show a fix nor does it show the version before these became an issue which was perfectly working.

    I really wish you guys would hear me.

    • This reply was modified 9 months, 1 week ago by Alundra.
    • This reply was modified 9 months, 1 week ago by Alundra.

    Ok, let’s try something.

    Please take a snapshot of the site using the All in one plugin – https://www.ads-software.com/plugins/all-in-one-wp-migration/. Then, send it our way via our website – https://creativethemes.com/blocksy/support/

    I’ll have the developers fully analyse the spacing on the most recent patches of Blocksy to see what’s what.

    Please don’t forget to send the exact pages where this is happening on.

    Other than that, from what we’ve seen on the front end I can assure you that everything is working as it should and as it was in previous Blocksy versions.

    Thread Starter Alundra

    (@alundra)

    Can you pass my screenshot about the spacing being too big regardless of setting please? They’re double what I think they should be to be comfortable, considering the spacing for the HEADER is the only thing changing it’s really distracting and it breaks the website.

    View post on imgur.com

    • This reply was modified 9 months, 1 week ago by Alundra.
Viewing 15 replies - 16 through 30 (of 30 total)
  • The topic ‘There’s a massive margin bottom on every header since updating.’ is closed to new replies.