Timeline disappeared after Update to WP 4.6

oops tell a lie, it worked on our development version of the site (hosted on wordpress specific hosts) but not on the clients live site with their own hosts unfortunately. This is the error log from chrome…

jquery.js?ver=1.12.4:2 Uncaught RangeError: Maximum call stack size exceeded
[Symbol.replace] @ (program):566
[Symbol.replace] @ (program):675
replace @ (program):121
camelCase @ jquery.js?ver=1.12.4:2
css @ jquery.js?ver=1.12.4:3
get @ jquery.js?ver=1.12.4:3
css @ jquery.js?ver=1.12.4:3
(anonymous function) @ jquery.js?ver=1.12.4:5
Y @ jquery.js?ver=1.12.4:3
n.fn.(anonymous function) @ jquery.js?ver=1.12.4:5
util.js:207 Google Maps API warning: NoApiKeys https://developers.google.com/maps/documentation/javascript/error-messages#no-api-keys

This site does have quite a few announcements, but was working perfectly before.

EDIT: it’s now not working again on the dev site either, haven’t made any changes.

I’m thinking this is directly related to the new script included, which allows for the announcement containers to be closer – and to avoid the gaps.

I will either have to re-write the function that adds the spacing, or revert it back to it’s previous state where the collision detection wasn’t present.

I’ll need to push out a patch soon, to get this resolved as it is effecting a number of (but not all of) our users.

Thanks,
Evan

Evan,

maybe you could have a tickbox which allows the user to not include the new collision detection?

@newboy9705,

That’s not a bad idea. I will look into getting some sort of option incorporated, that will be disabled by default. that’s probably the best course of action moving forward, at least until I can figure out what’s going on on certain installs, but not others.

Evan

@evan

I’ll be happy to test it for you before you release it into the wild …

Please how to workaround this problem?

Hi,

while we are waiting for Evan to put in a proper fix I’ve implemented a workaround on my system.

The work around is not pretty, in fact its quite ugly, but any bodge which works isn’t a bodge …

So the fix is to rename the file

wp-content/plugins/timeline-express/lib/public/js/jquery-collision.js

to

wp-content/plugins/timeline-express/lib/public/js/waiting-for-evan-to-fix-jquery-collision.js

The fact that this works supports Evan’s theory the problem is caused by his new collision detection feature.

I hope someone finds this useful, if this does or doesn’t work for you, please let us know as it will help Evan create a proper fix.

Ive removed the option for now and things should be working once again in the latest release.

I will have to come up with an alternate solution in a future release.

Thanks,
Evan

Thanks Evan, your latest version fixes the problem I was seeing.

hmm the timeline is now displaying, but its not looking quite as good as it did before for me. This is the development version of the site:

https://baxterhoare-backup.flywheelsites.com/about-us/history/

As you can see, the entries are now overlapping, and the actual line itself not showing. I’ve not changed anything else. This remains an issue for our client’s webpage. Any advice?

EDIT: OK so I’ve sorted the line colour (was this always an option in the back end?) but the overlapping is the main issue.

• This reply was modified 8 years, 2 months ago by john_pawson.

The collision detection was removed from the plugin as this is what was causing problems. The reason they are colliding is beacause some of your content has images with long content body, while others are shorter with no images. This causes the behavior. You can unify your announcement lengths to work around the issue, or add a top margin to the item that is overlapping.

Evan

Damn.

Is there no other way round this (like rolling back to an older version of the plugin perhaps?) The client has this on the live version of the site, so I need a quick resolution. Adding a top margin might work, but there’s a whole bunch of these that are overlapping and that includes the icons on the timeline itself. Reworking content is going to be a no-go for us, considering this will likely take quite some time, and the client will probably be unlikely to want to pay us again for something that was previously working.

Cheers again! Great support.