Translating?

  • Resolved pouipouidesign

    (@pouipouidesign)


    9 years, 11 months ago

    Hi, loving the plugin this far but I’ve a multilingual site (with WPML) and I can see that in osd-social-media-sharing/includes/OSDSocialShare.php there is an untranslatable string : “Click to share on “, which is really too bad since it’s only the one string.

    Would you consider updating this to __("Click to share on ","osd_plugin") (or whatever you prefer for domain) ?
    It would really be cool as it would allow for translation without preventing updates, which is what’s going to happen if I modify this myself ^^

    Thanks a lot in advance for your consideration!

    https://www.ads-software.com/plugins/osd-social-media-sharing/

Viewing 10 replies - 1 through 10 (of 10 total)
  • Plugin Author osdwebdev

    (@osdwebdev)

    pouipouidesign,

    This is a great idea and we will implement as soon as we have a moment to do so. Thank you very much for the suggestion.

    Thread Starter pouipouidesign

    (@pouipouidesign)

    \o/
    Great, thanks for accepting!
    Keep me posted when it’s done, so that I can update and translate ??

    Thread Starter pouipouidesign

    (@pouipouidesign)

    Hello,
    Just so that I can get organized (I’m supposed to deliver very soon/this week), when do you think you’ll be able to push that update?
    Thanks!

    Plugin Author osdwebdev

    (@osdwebdev)

    pouipouidesign,

    I just got back to this request. So sorry about the delay. I added what I think should give you the ability to translate that line. If you send me back your translation I will put it in the lang file and update the plugin again. Please test to make sure all is correct and let me know.

    Thank you for your patience.

    Plugin Author osdwebdev

    (@osdwebdev)

    Feel free to email @ [email protected]

    Thread Starter pouipouidesign

    (@pouipouidesign)

    Hello,

    Thanks a lot for this! I’d given up on it happening but it’s great to know it wasn’t forgotten and finally happened ??

    I’ve updated and it all seems to work fine, WPML is seeing the string and allowing me to translate it.

    My client will be doing the translating in all the languages she requires, but I can still give you the French version : “Cliquez ici pour partager sur ” (but, as in English, that doesn’t work so well for Email sharing, which would be more correct as “Cliquez ici pour partager par ” (“by” instead of “on”).).

    Anyway, thanks again, I’ll mark this as resolved if that’s ok?

    Plugin Author osdwebdev

    (@osdwebdev)

    That would be great.

    I went ahead and corrected the grammar issue, thank you for pointing that out. You should now have the line for email using the word ‘by’. Let me know if that works please.

    Thread Starter pouipouidesign

    (@pouipouidesign)

    Hmmm, how should I go about checking this latest mod?
    Can’t see an update for the plugin in my dashboard?

    Thread Starter pouipouidesign

    (@pouipouidesign)

    Obviously, manually downloading it and uploading on the server did the trick, sorry ^^

    It works super fine, thanks for adhering to this degree of precision! ??

    I’m marking this resolved, have a very excellent week-end!

    Plugin Author osdwebdev

    (@osdwebdev)

    You as well!

Viewing 10 replies - 1 through 10 (of 10 total)
  • The topic ‘Translating?’ is closed to new replies.

Tags