Translation of wp-login form Problems

if i delete the (in my opinion unnecessary parameter -> ‘all-in-one-wp-security-and-firewall’) – pooof – translations are back!

• This reply was modified 6 years, 10 months ago by markmaurerrr.

The following strings are what you see in the login form.

Username or Email Address
Password
Remember Me
Register | Lost your password?
← Back to WP Test
Privacy Policy

The plugin does not edit any of the above strings. Those strings are managed by WordPress. I have a few Spanish sites running the latest version of AIOWPS and WordPress without any issues. You might have your theme or perhaps another plugin in your site that is editing those strings.

Regards

@mbrsolution

…

would be nice if one of the developers could join the chat as this is not very productive. I really want to help but it doesn’t seem like it’s pointing in the right direction.

You haven’t changed the string, but you have added a parameter to the translation function, which is causing the issue (as already mentioned multiple times)

Try it with the german language to reproduce the issue, it wont take more than 2 minutes:
1. install wordpress
2. add the official wordpress german translations
3. install AIOWPS Version 3.2.x -> translations aren’t working
4. install AIOWPS Version 2.7 -> translations are working
why?
because you have changed the translation function!

Another screenshot for you of the AIOWPS update commit revert i did on many websites. you can see the difference between version 2.7 and 3.2.

https://prnt.sc/jniezu

Hope the issue is clear now and will be solved soon, as this is really a very simple five minute task. Thanks.

• This reply was modified 6 years, 10 months ago by markmaurerrr.

Hi @markmaurerrr, I understand what you mean. I am curious to know why are you installing AIOWPS Version 3.2.x instead of version 4.3.3.1 which is the latest version?

Regards

I think what @markmaurerrr is trying to point out is that strings such as

__('<strong>ERROR</strong>: Enter a username or e-mail address.' )

or

__('<strong>ERROR</strong>: Invalid username or email.' )

are no plugin-specific strings (and therefore do not need to be in the plugins domain).

When you remove the all-in-one-wp-security-and-firewall in the function call, it will fall back to the default WP translations (which is totally fine, because all of the core strings are of course translated into german)

@mbrsolution
… of course the major is 4?!

i thought it is clear that it’s
4.3.2.x
and
4.2.7.x
in my last post.

(Bug is also in the latest 4.3.3.1)

• This reply was modified 6 years, 10 months ago by markmaurerrr.
• This reply was modified 6 years, 10 months ago by markmaurerrr.
• This reply was modified 6 years, 10 months ago by markmaurerrr.
• This reply was modified 6 years, 10 months ago by markmaurerrr.

Hi @markmaurerrr, I have submitted a message to the developers to investigate further this issue.

Thank you

This looks more like the translation file is just not being recognized.

Are you maybe using the formal German langauge setting in your site? I think its Duetsch (Sie)

We don’t currently have and language file for that version of German. I think that one needs to have the following:

all-in-one-wp-security-and-firewall-de_DE_formal.po
all-in-one-wp-security-and-firewall-de_DE_formal.mo

That maybe the issue.

@mra13

Please read the whole topic, i’ve put in the effort to report everything pretty detailed so i would really appreciate if you take your time to dive into the topic.

Why would you ever use a security-and-firewall-de_DE_formal.po if the login translations are already in the standard wp translations. Why have you added the ‘all-in-one-wp-security-and-firewall’ parameter to the function call? it just makes absolutely no sense – you’re causing redundancy in translation strings.

Please roll back at this part of the plugin and remove the dependency of a custom tranlsation file for strings that are already translated for almost every language.

Thanks

• This reply was modified 6 years, 9 months ago by markmaurerrr.

Maybe I am not understanding this correctly (I am not super good with translation).

If there is a translation string for the following done for our plugin and the correct translation file exists, why wouldn’t the translation work? Isn’t the translation from our plugin suppose to override it?

'<strong>ERROR</strong>: Invalid username or email.'

We want ALL the translation (for anything that our plugin outputs) to be customizable via our plugin’s language translation file. We don’t want it to fallback to the standard WordPress translation (since the output of the renamed login page comes from our plugin). We normally don’t want to lose the ability for our other users who want to customize all those texts via our language file. Maybe for these specific texts the translation works differently (and I don’t understand it fully).

What am I missing?

• This reply was modified 6 years, 9 months ago by mra13.

Dear @mra13,

this feature: “Enable Rename Login Page Feature” does nothing more than just making the wp-admin accessible under another url. This login page is wordpress standard and a whole bunch of people already have put the effort in this to translate it and it’s done for almost every available language. Those are not your strings, those are standard wordpress strings.

I just can’t find the words to describe how senseless it is for you to create your own translation strings, create a big translation string redundancy and demand people to translate strings that are already existing.

As you’re just changing the login url, the content should be 100% the same as on the standard wordpress (which are already translated), so please tell me one reason why you have changed this after Version 4.2.7.x. It was working fine and now you’ve made a mess in this feature.

You are kind of just looking at your situation as opposed to what provides an option for all parties involved. So what do we tell our customers who want to customize the rename login page? Where the output comes from our plugin?

Hi Mark,
When you use the rename login page feature, the “login page” output strings are not coming from the standard wp-login.php file but instead come from a file inside the aiowps plugin. That file is called wp-security-rename-login-feature.php which resides in the “other-includes” directory of this plugin.
Hence the reason for the translations being required.

@mra13

You are kind of just looking at your situation as opposed to what provides an option for all parties involved

Definitely not. This is exactly what you’re doing at the moment.

You should create use cases from a users perspective, not your perspective.

You have a feature that is called “Enable Rename Login Page Feature”. This feature is supposed to change the url of the login, so no brute forces attacks can be done under this url.

Ok, so i (a normal wordpress user) just want to have that little feature. My whole wordpress login is perfectly translated. Now i will activate this feature in your plugin. The url has change but now the login is in english and not in my language anymore.

What do you think the normal user will do if the login has to be hin his language again?
1. Put in loads of effort to translate every string as your plugin isn’t well translated yet.
2. Just don’t use this feature again, because it was working before. The effort of translating all that stuff is not worth it.

It’s definitely 2. Also remind that a whole bunch of wordpress users aren’t developers and they have absolutely no idea where to change that. The only thing they see is:
wordpress login was working before?– i activated the feature – my translations are gone.

What you’re talking of is a feature called “customize login page contents” that makes no sense for me to have in a wordpress security plugin. And even if people want to change the standard wordpress strings, they easily can do that by using Loco Translate or custom translation overrides.

What you’re talking of is just making sense if you have a new feature that has custom strings created by you, and you’re not using strings that are already included in standard wordpress (and already translated).

@wpsolutions
Mate, sorry but you’re exhausting. What you’re writing is just 100% wrong and i will now explain you for the last time that if you just remove the ‘all-in-one-wp-security-and-firewall’ parameter from the function call and you’re using the standard wordpress strings (what you’re doing) the standard translations are running.

What really annoys me is that (as i told you more than five times now) you was doing it right until 4.3.x. It was working before because you was doing it the way i am talking about all the time. And now you’re telling me that this can’t work? Are you serious?

• This reply was modified 6 years, 8 months ago by markmaurerrr.

Ok fair enough dude. Upon some reflection I think you make a valid point.

We’ll remove the ‘all-in-one-wp-security-and-firewall’ parameter from the translation functions in the rename login page file.