Translations not working

Hey,

For the issues you are referencing in this forum most were solved by me simply adding the translations to the plugin, I’ve not been able to create issues with using loco translate but for everyone that I am aware of that were having issues when I added the translation into the plugin their issues went away. If you would like me to include your translation in the next update send it to [email protected]

Side note, are you using a multilingual site? that might be totally different as some multilingual plugins have issues with triggering emails in the correct language.

Ben

@britner

Hello Ben,

I just found out that the translation problem with LOCO translate is the following:

1. Kadence uses the Loco translation correctly when it is stored in “languages/plugins/” default folder (which is not recommended by loco as it can be overwritten)

2. Kadence ignores the Loco translation when it is stored in (update safe) “languages/loco/plugins/” folder

You find more details here: https://bit.ly/2pvq118 Choose a location -> Custom (recommended)

This methods works well with other plugins.. Would be great if you could make it work “correctly” with kadence

Thank you very much!

Best regards,

Stefan

I’ll look into this more, it’s a good use case to start trying to recreate.

Just for clarification Kadence doesn’t “ignore” translations, plugins don’t control the functionality behind translations that is all handled by core WordPress. Our plugin is using the same function calls as every other plugin or theme to register strings through the functions inside of WordPress core.

But regardless I’ll see what I can figure out by recreating your setup.

Ben

This is what is happening in my case;

Woocommerce email templates;
Admin language – English or Korean
Site language- Korean
Browser – English
Emails to customer generated in Korean
Emails to admin generated in Korean

Kadence emails templates;
Admin language – English
Site language – Korean
Browser – English
Emails to customer generated in English (customizer Korean)
Emails to admin generated in English (customizer Korean)

Admin language – Korean
Site language – Korean
Browser – English
Emails to customer generated in Korean (customizer Korean)
Emails to admin generated in Korean (customizer Korean)

@britner Thank you Ben for looking deeper into this!

What would be great if one can 100% “trust” that the translations done with loco translate (update safe directory) e.g. for woocommerce or subscription email strings incl. subject/title are 100% carried over to Kadence mails as long as nothing is changed in kadence customizer.

After working with Kadence for a while (thank you for developing and maintaining this!) I figured out that at least sometimes the problem is, that the strings in “your” mail templates are slightly different from the original e.g woo or subscriptions ones. Maybe because they changed during an update and you sometimes still use the older templates?

I also do not understand the need for additional email content translation strings in kadence translation files itself – since maintenance wise the translations are better already done in the corresponding plugins themselves (e.g. woo, woo subscriptions) and “get in effect” if they exist, right?

One more thing Ben – I think you told me once, that if one makes changes to the Mail content via Kadence Customizer, the custom text is stored in the DB and cannot be changed back to default ones as soon as one saves.. Is this correct? If yes, it would be great if you could add an option to reset each mail’s custom content to default..

Thank you!

Best regards,

Stefan

The latest update includes a function to force the translation to use the site language. I believe that will resolve any issues with loco.

In the string is in side this plugin ( which many strings have to be to allow the kind of editing control you get with this plugin) then they have to use our text-domain based on how WordPress standards work.

Which strings specifically are you seeing that are different? Can you list them here?

There is a reset button at the top of the customizer. But to be clear once you use this plugin (doesn’t matter if you save or not) the strings will all come from this plugin and this plugins translations even if it’s blank, it’s still going to use a string in this plugin. That string still has to be translated if it’s not currently part of the translations. This is simply because the files in use are from this plugin and all translations within a plugin have to use the text domain of that plugin.

Once you save something into the database that will remove the “placeholder” text which is part of the plugins translatable text.

I hope that better makes sense.

Ben

Hey Ben,

After installing the update and testing it out, I’m glad to say the translation issues are no more!

Thanks for the fix! This plugin is great!

Thanks again for all your efforts!

Regards

Oliver