Translations of JS files

  • Resolved McLibboc

    (@mclibboc)


    1 year, 10 months ago

    Since the topic https://www.ads-software.com/support/topic/translations-207/ has been closed, I open a new one.

    As far as I can tell, translations of strings that are inserted via JS fail, resulting in a mixture of, in my case, English and German on the statistics page.

    I have made sure that translations for all strings are available at 

    wp-content/languages/plugins

    in the form of json files, that I generated with 

    wp i18n make-json burst-statistics-de_DE_formal.po

    and

    wp i18n make-json burst-statistics-de_DE.po

    respectively.

    However, I only ever see the English strings.
    Could you please advise?

    The page I need help with: [log in to see the link]

Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Author Hessel de Jong

    (@hesseldejong)

    Hi @mclibboc,

    Burst was not fully translated into German. We have just added the German translations to the WP repository. So an update of the translations should appear in your dashboard anytime soon.

    Thank you for bringing this issue up to us.

    Kind regards,
    Hessel

    Thread Starter McLibboc

    (@mclibboc)

    Hi @hesseldejong,

    thanks for your quick response.

    To clarify: I first completed the German translation, and in particular also the German (Formal), which I am interested in most, at https://translate.www.ads-software.com/projects/wp-plugins/burst-statistics/

    I then downloaded the resulting .po files and treated them as described above.

    I will wait to see if the addition to the WP repository will make any difference. Could you please also add the locale de_DE_formal to the repositiory?

    Thx!

    Plugin Author Hessel de Jong

    (@hesseldejong)

    Hi @mclibboc,

    We have just added the formal German translations as well. I hope this is sufficient for it to work properly on your website.

    Thanks a lot for translating our plugin. We appreciate it a lot!

    Kind regards,
    Hessel

    Thread Starter McLibboc

    (@mclibboc)

    Hi @hesseldejong,

    Ok, thanks, now I am beginning to see the translation changes I made to the de_DE locale yesterday, so apparently the repository changes for that are in effect now.

    However, that still doesn’t seem to affect the language dependent parts of the javascripts:

    green border: translated strings, red border: unstranslated strings.

    Most of the untranslated strings have translations in the .po file and all of them stem from Javascipt files.

    I suspect that something might not be OK with script registration, maybe see https://wordpress.stackexchange.com/questions/355472/how-to-load-translation-in-javascript

    • This reply was modified 1 year, 10 months ago by McLibboc.
    Plugin Author Hessel de Jong

    (@hesseldejong)

    Hi @mclibboc,

    Thanks a lot for your detailed explanation. It was indeed a wrong string in the function that registers script translations. Thanks a lot for investigating.

    I have made a fix, in this branche: https://github.com/Really-Simple-Plugins/burst/tree/1.3.4-Translation-issue-fix

    Could you try it out and check if it solves your issue?

    Edit: I see there are still some strings that are not translated. E.g., Months, days and the headers in the data tables. We’ll try and get this fixed in the next update.

    Kind regards,
    Hessel

    Thread Starter McLibboc

    (@mclibboc)

    Hi @hesseldejong,

    your fix in settings.php did the trick, thanks a lot!

    Yes, there are still some untranslated strings, but I can happily wait until those get incorporated in later versions.

    I had some basic misunderstanding when translating strings containing placeholder elements with %s. I corrected those errors at https://translate.www.ads-software.com/projects/wp-plugins/burst-statistics/

    Best regards,
    McL

    • This reply was modified 1 year, 10 months ago by McLibboc. Reason: resolved
Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘Translations of JS files’ is closed to new replies.