typography still broken in 2.0.2

  • Resolved lano1106

    (@lano1106)


    7 years, 2 months ago

    Here is the generated inline CSS:

    .saboxplugin-wrap .saboxplugin-authorname{font-family:”none”}.saboxplugin-wrap .saboxplugin-desc{font-family:none}

    BTW, why font-family is in quote and the other isn’t??

    Temporary workaround:
    Just pull out the PHP lines creating the font-family style and including the ‘None’ Google fonts

Viewing 5 replies - 1 through 5 (of 5 total)

  • @lano1106 – this was actually the reason we’ve released the v2.0.2 update, to fix this exact typography issue.

    We’ll look into it and release another update. From our tests, it appeared to be fixed.

    Thanks,
    Cristian.

    Thread Starter lano1106

    (@lano1106)

    I know!

    With 1.9, your plugin was trying to fetch the nonexistant ‘None’ Google font. I did pull out the lines doing that.

    With 2.0.1, I didn’t check the google font but inline CSS for font was fine. The 2.0.2 typography fix had the regression effect for me as described in initial post.

    diff -r simple-author-box/inc/class-simple-author-box-helper.php /home/lano1106/Downloads/simple-author-box/inc/class-simple-author-box-helper.php
    45a46
    > ‘vk’ => ‘VK’,
    905c906
    < if ( get_option( ‘sab_box_name_font’ ) != ‘none’ ) {
    —
    > if ( get_option( ‘sab_box_name_font’, ‘None’ ) != ‘None’ ) {
    911c912
    < if ( get_option( ‘sab_box_desc_font’ ) != ‘none’ ) {
    —
    > if ( get_option( ‘sab_box_desc_font’, ‘None’ ) != ‘None’ ) {
    917c918
    < if ( isset( $sabox_options[‘sab_web’] ) && get_option( ‘sab_box_web_font’ ) != ‘none’ ) {
    —
    > if ( isset( $sabox_options[‘sab_web’] ) && get_option( ‘sab_box_web_font’, ‘None’ ) != ‘None’ ) {

    • This reply was modified 7 years, 2 months ago by lano1106.

    Could you please try going to the typography tab and hitting the save button? We need to overwrite the old plugin values that previously existed in the DB ??

    Thanks,
    Cristian.

    Thread Starter lano1106

    (@lano1106)

    Thx Cristian, It makes sense.

    Consider my problem fixed!

    However, considering the size of your userbase, I feel like I am not the only one who is going to have that problem…

    I’m not a plugin developer like you so I don’t know what I’m talking about but there might be a way to install a hook to call a function when upgrading a plugin that could take care of upgrading the plugin DB tables…

    Might be worthwhile to explore that possibility soon or at least for the next upgrade.

    Take care and I really appreciate your good work. I will give your plugin a 5-stars pretty soon!

    Olivier

    Hi Oliver,

    yep, that’s what we’re already considering ?? Expect the new release to address this!

    Thanks,
    Cristian.

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘typography still broken in 2.0.2’ is closed to new replies.