Undefined Variable in v 2.3.1

Viewing 10 replies - 1 through 10 (of 10 total)
  • Thread Starter billsmithem

    (@billsmithem)

    FYI: This was not happening in the previous version, this is after the upgrade. I tried it twice, reverting to the previous version which does not display the error before attempting the upgrade a second time with the same results.

    Plugin Author smashballoon

    (@smashballoon)

    Hey Bill,

    Thanks for letting me know. I’ll get this fixed in the next update and apologize for any inconvenience.

    John

    mswas

    (@mswas)

    I get a similar undefined variable in 2.3.1

    Notice: Undefined index: cff_font_source in …/wp-content/plugins/custom-facebook-feed/custom-facebook-feed.php on line 1789

    Thread Starter billsmithem

    (@billsmithem)

    mswas, latest version of php now defaults to displaying non-fatal errors, such as using undefined variables. The change will cause a lot of previously unnoticed errors to appear in working code.

    In this case, the logic works either way, whether the variable is undefined or not set to a particular value, the result is the same. But undefined variables can cause some rather odd bugs, so in the long run stronger error checking is a good thing.

    Plugin Author smashballoon

    (@smashballoon)

    For sure, I’ll get this taken care of in an update today guys. Apologies for any inconvenience and thanks for your patience!

    John

    Plugin Author smashballoon

    (@smashballoon)

    I’ve just pushed out an update (2.3.2) which should fix this issue. Please let me know if that’s not the case or if you notice any other PHP notices that shouldn’t be there.

    John

    Thread Starter billsmithem

    (@billsmithem)

    John,

    You neglected to initialize Icon Font Source, causing undefined index errors:

    Notice: Undefined index: cff_font_source in …/wp-content/plugins/custom-facebook-feed/custom-facebook-feed.php on line 1791

    Notice: Undefined index: cff_font_source in …/wp-content/plugins/custom-facebook-feed/custom-facebook-feed.php on line 1793

    until you go to to the bottom of the page at Customize->Misc, where I changed Icon Font Source from CDN to CDN and hit save.

    Thread Starter billsmithem

    (@billsmithem)

    And thanks for the prompt update…

    Plugin Author smashballoon

    (@smashballoon)

    Strange, I didn’t get that notice when testing earlier. I’ll check again and push out a fix. Thanks for letting me know.

    John

    Plugin Author smashballoon

    (@smashballoon)

    Just pushed out another update to fix this. Sorry about that. I’ve tested this one extensively and it seems good on my end. It’s 1am here and I’m a little groggy so I’m hoping I didn’t miss anything but if I did and there are any other issues then just let me know and I’ll get them fixed tomorrow.

    Have a great weekend!

    John

Viewing 10 replies - 1 through 10 (of 10 total)
  • The topic ‘Undefined Variable in v 2.3.1’ is closed to new replies.