Unexpected output and lots of other errors

  • Resolved Pieter Bos

    (@senlin)


    10 years, 5 months ago

    When I activate the plugin I get the message that it generated unexpected output during activation:

    The plugin generated 277 characters of unexpected output during activation. If you notice “headers already sent” messages, problems with syndication feeds or other issues, try deactivating or removing this plugin.

    Deactivating the plugin results in a Strict Standards warning:

    Strict Standards: call_user_func_array() expects parameter 1 to be a valid callback, non-static method Class_Footnotes::deactivate() should not be called statically in /path/wp-includes/plugin.php on line 470

    Reactivating gives the same message again and the settings page also contains Warnings:
    Warning: Missing argument 3 for do_meta_boxes(), called in path/wp-content/plugins/footnotes/classes/footnotes_settings.php on line 140 and defined in path/wp-admin/includes/template.php on line 942

    And on the howto settings tab:
    Notice: Undefined index: footnote_inputfield_collapse_references in path/wp-content/plugins/footnotes/includes/replacer.php on line 321

    On top of all this the entire Edit Posts screen fails to function properly with the plugin activated.

    In short: COMPLETE FAIL

    I was expecting a bit more for a plugin that was recently featured on wpmudev…

    https://www.ads-software.com/plugins/footnotes/

Viewing 15 replies - 1 through 15 (of 28 total)
  • Plugin Author Mark Cheret

    (@markcheret)

    Hi Piet,

    thank you for taking the time to write to us!
    I’m sorry to hear that the plugin doesn’t work for you.

    As it works with our testing environments, we need a little more info to troubleshoot your problems.
    Could you please send us, what HTTP-Server you’re using, and your php.ini settings. Only then are we able to replicate your environment and troubleshoot the issues you’re having.

    Thread Starter Pieter Bos

    (@senlin)

    I installed the plugin on a local dev site OSX Mavericks using MAMP Pro 2.1.1, PHP 5.4.4, cannot find the php.ini file

    Plugin Author Mark Cheret

    (@markcheret)

    Hi Piet,

    thanks again for reporting back.
    We’re currently preparing a Bugfix Release with your feedback in mind.
    Stay tuned, should become available shortly.

    Meanwhile, I will replicate your environment to test things.

    Plugin Contributor Stefan Herndler

    (@aricura)

    Hi Piet,

    many thanks for your helpful report!
    We published a new Release including your reported Bugs right now.

    Plugin Author Mark Cheret

    (@markcheret)

    Hi Piet,

    I replicated your environment as best as possible and installed MAMP Pro 3, a fresh WordPress 3.9.1 and our footnotes plugin with the latest Version. There were no issues installing, activating, using, deactivating and deleting the plugin.

    Please check out the latest plugin version and report back.

    Cheers

    Thread Starter Pieter Bos

    (@senlin)

    Thanks for you quick actions guys, the plugin works error/notice/warning free now!

    One thing thing though that has nothing to do with the previous things, is that although the plugin comes fully internationalised, the one variable that the user can fill in, cannot be translated (using WPML).

    To solve that you need to add that to what is called a wpml-config.xml file that needs to be included in the plugin. Many plugin authors already include such a file, as an example Joost (of WordPress SEO).

    There is more info available on adding such a file (to the plugin) at the WPML website: https://wpml.org/documentation/support/language-configuration-files/

    Would be awesome if you can include that file ??

    Off to writing my review now ??

    Thread Starter Pieter Bos

    (@senlin)

    sorry, bit too soon

    The issue of the distorted edit posts/pages screens is still there.

    See my screenshots to illustrate the issues.

    Piet

    footnotes activated

    footnotes deactivated

    Plugin Author Mark Cheret

    (@markcheret)

    Thanks for the feedback!

    We’ll have a look at this right away. I hope you can live with the annoyance the distortion poses at the moment until we have a fix.

    I’m looking into the WPML xml file at the moment. Seems easy to solve.

    Plugin Author Mark Cheret

    (@markcheret)

    can you give this a spin in your installation?

    https://cheret.de/wp-content/plugins/footnotes/wpml-config.xml

    Thread Starter Pieter Bos

    (@senlin)

    Your file is not working, I played around with it a bit and I got the following working although it still gives a notification that it might have some strings that have not been registered. I can make the file, but need to know how exactly the options are registered.

    this is what is working, but not 100%

    <wpml-config>
	<admin-texts>
		<key name="footnotes_storage">
		    <key name="footnote_inputfield_references_label" />
		</key>
	</admin-texts>
</wpml-config>

    The distortion turns out to be all over the place in all admin screens, plugins settings screens, everywhere throughout the backend, not sure where it’s coming from, but looks like a CSS that is not properly enqueued to only work on your plugin’s page…

    Thread Starter Pieter Bos

    (@senlin)

    yeah the settings.css is just enqueued without any conditions (line 45 of index.php the scripts are included and from that file they are enqueued).
    my best guess is that you need some conditionals around that ??

    Plugin Author Mark Cheret

    (@markcheret)

    Cheers! We’ll check it out.

    Plugin Contributor Stefan Herndler

    (@aricura)

    Many thanks for the response and testing Piet.

    In the current development version our CSS files will only be added on our Plugins settings page and nowhere else. This should solve your styling problems.

    Plugin Author Mark Cheret

    (@markcheret)

    If you’re willing to put together the wpml-settings.xml, all registered options can be found in this file:

    https://plugins.svn.www.ads-software.com/footnotes/trunk/includes/defines.php
    they start with FOOTNOTE_INPUTFIELD the value you need is in lower case

    Thread Starter Pieter Bos

    (@senlin)

    Sorry, was having dinner…

    Cool, I’ll try to get it working and post it here once it is.

    Your code is not on Github, is it?

Viewing 15 replies - 1 through 15 (of 28 total)
  • The topic ‘Unexpected output and lots of other errors’ is closed to new replies.