Uninitialized string offset login_bg_color in login-form-screen

  • I don’t know if this a consequence of the import settings that went wrong, but i had new issues triggered in login-form-screen.php

    Notice: Uninitialized string offset: 0

    line 64
    if ($colour[0] == '#'

    coming from a bad value in line 81:
    $loginbg = weblizar_hex2rgb($login_page['login_bg_color']);

    I found that ($login_page['login_bg_color'] values was ''. Consequently weblizar_hex2rgb cannot parse the RGB color.

    But that’s only set when you use a login BG color. I’m using a login BG image. I could fix that problem by switching to BG color, setting a color, and going back to login BG image…

    I found similar issues in login-inline-css.php.
    Notice: Trying to access array offset on value of type bool.

    It seems it also came from login_bg_colorbut i suspect also login_form_opacity to have similar problems.

    Not 100% sure but everything should be checked to be sure that default values are valid even if you don’t select a particular option (e.g. color vs image).

Viewing 1 replies (of 1 total)
  • Thread Starter herrvigg

    (@herrvigg)

    Actually, regardless of the current values (set or not), more checks should be done to be sure the relevant fields are only read when the related option is selected (e.g. bg color vs bg image). Some fields are shared, but some are specific. Those are a potential source of bugs until better checks are added.

    • This reply was modified 3 years, 10 months ago by herrvigg.
Viewing 1 replies (of 1 total)
  • The topic ‘Uninitialized string offset login_bg_color in login-form-screen’ is closed to new replies.