Untested with PHP8?

  • Resolved davorg

    (@davorg)


    10 months, 2 weeks ago

    I’m running my WP site on PHP 8.1.28 and, following an update to WP RSS Aggregator (to 4.23.8) my site is throwing deprecation warnings:

    Deprecated: Return type of Twig\Node\Node::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/dave.org.uk/httpdocs/wp-content/plugins/wp-rss-aggregator/vendor/twig/twig/src/Node/Node.php on line 213

    Deprecated: Return type of Twig\Node\Node::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/vhosts/dave.org.uk/httpdocs/wp-content/plugins/wp-rss-aggregator/vendor/twig/twig/src/Node/Node.php on line 221

    I see the plugin directory says it has been tested up to PHP 6.5.3 – but I don’t know anyone who uses a PHP that old.

    Do you have plans to test the plugin with a recent version of PHP?

Viewing 5 replies - 1 through 5 (of 5 total)
  • Plugin Support Hendra Setiawan

    (@hendcorp)

    Hi @davorg

    Thank you for bringing this to our attention. While version 4.23.8 aimed to resolve several compatibility issues, we acknowledge that it did not completely eliminate all PHP 8 deprecation issues. However, I’m pleased to inform you that we are actively working on Aggregator v5.0, which will be fully compatible with PHP 8.x.

    We appreciate your patience and understanding as we strive to enhance your experience with RSS Aggregator. If you have any further questions or need assistance, please feel free to reach out.

    Thread Starter davorg

    (@davorg)

    Hi @hendcorp, thanks for the reply.

    I was just looking at your GitHub repo. It looks like you don’t have any CI process in place (or, at least, not one that uses GitHub Actions). Would you be interested in getting some help in setting up CI that automatically runs you unit tests against several PHP versions on every commit?

    Plugin Support Hendra Setiawan

    (@hendcorp)

    Hi @davorg

    Thank you for taking the time to review our GitHub repository and for offering to help with setting up CI using GitHub Actions for Aggregator. We truly appreciate your willingness to contribute and your expertise in this area.

    However, after careful consideration, we have decided to focus on our current development processes and will not be implementing CI with GitHub Actions at this time.

    Thank you once again for your offer and understanding.

    Thread Starter davorg

    (@davorg)

    Hi,

    I’ve been looking into this in a bit more detail. It seems the problem isn’t with your code, but with the Twig library that you use. And looking at their repo, I see this is a problem that they fixed three years ago. (see https://github.com/twigphp/Twig/commit/98c2233e4734ccc1b5b357bba5c712bb53fc3b23).

    So it looks like the problem would go away if you just updated the version of Twig that you’re pulling into your codebase.

    Is that something you could do simply?

    Cheers,

    Dave…

    Plugin Support Hendra Setiawan

    (@hendcorp)

    Hi @davorg

    Unfortunately, no. The current version of Aggregator (v4.x) uses Twig v1, which has not been updated to be fully compatible with PHP 8. The updated version that you are seeing is Twig v3, and updating our version of Twig from v1 to v3 is not a simple task.

    However, our upcoming v5 update will not use Twig at all. Therefore, we consider Aggregator v5.0 to be the ultimate solution to this issue.

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘Untested with PHP8?’ is closed to new replies.