Update jetpack function

  • Resolved Brandon Kraft

    (@kraftbj)


    Code Wrangler

    3 years, 4 months ago

    Howdy!

    I’m a developer for Automattic working on Jetpack. I noticed that you’re using the jetpack_photon_parse_url function in frontend/class-frontend.php L65.

    We’re looking at removing this function from Jetpack as wp_parse_url is fully compatible with it. wp_parse_url in WP 4.7 was updated to include the second argument and since that’s your minimum WP version, everyone running the latest version of your plugin should be able to use wp_parse_url instead of the jetpack_photon_parse_url function.

    We can punt removing the function for a bit to allow your users to update to a newer version, but please do let me know when you’d expect to be able to update it so I can note it in our internal docs.

    Please let me know if you have any questions and thank you!

Viewing 1 replies (of 1 total)
  • Plugin Author Alan Fuller

    (@alanfuller)

    Thanks for the reminder. I was using that in a filter jetpack_photon_skip_for_url as jetpack was breaking external Eventbrite images by trying to optimise them.

    I have to admit I haven’t tested recently to see if Jetpack has improved in this area so I’ll leave that filter in for the moment.

    I have changed to wp_parse_url now in the dev code line.

Viewing 1 replies (of 1 total)
  • The topic ‘Update jetpack function’ is closed to new replies.