Update on use of wpdb->escape

  • I can see in this older thread (which is now closed) that the issue of using the deprecated $wpdb->escape() is already known, however in the latest version it is still required to manually hack domain_mapping.php to replace these calls with esc_sql().

    I was just interested in a quick update on whether this fix is being planned for inclusion in a new version? I’m happy to do it myself if I can (not entirely sure how to though, I haven’t contributed to a plugin yet!)

    https://www.ads-software.com/plugins/wordpress-mu-domain-mapping/

Viewing 9 replies - 1 through 9 (of 9 total)
  • Plugin Author Ron Rennick

    (@wpmuguru)

    The fix is in the development version.

    Thread Starter tdmalone

    (@tdmalone)

    Can it be placed into the official version by any chance?

    Plugin Author Ron Rennick

    (@wpmuguru)

    I’m not currently planning on releasing a new version unless there is a change in core WP that causes a problem with DM.

    Arbitrary URLs were added to WP core in version 4.4 so this plugin is no longer needed for new installs.

    Hi Ron,
    I’m using WP 4.4.2 with this plugin and all works well. You said:

    Arbitrary URLs were added to WP core in version 4.4 so this plugin is no longer needed for new installs.

    Are there any instructions for migrating away from this plugin and using WP 4.4+ core instead for domain mapping?

    Thanks

    Plugin Author Ron Rennick

    (@wpmuguru)

    If you already had domain mapped sites before 4.4 then you would need to keep using domain mapping or use a database search & replace to replace the unmapped URLs with the mapped one. Once the URLs are replaced then you shouldn’t need the DM plugin.

    Thanks, Ron. I might need a bit more detail to do that… do you know if there are any more WP instructions anywhere that describe how to 1. migrate away from DM plugin (which tables need changing, etc.) and 2. How to do the mapping in WP MU without the DM plugin?

    Unfortunately, I seems the official WP MU instructions still say the DM plugin is required.

    Thanks again.

    Plugin Author Ron Rennick

    (@wpmuguru)

    I seems the official WP MU instructions still say the DM plugin is required

    Can you provide a URL for where you saw said official instructions? WordPress MU became obsolete roughly 6 years ago.

    How to do the mapping in WP MU without the DM plugin?

    Go to Network Admin -> Sites -> Edit Site & edit the site URL.

    Hi Ron,
    The instructions I was referring to are at https://codex.www.ads-software.com/Before_You_Create_A_Network

    and contain this sentence:

    Additionally, you can map domains like example1.com, example2.com, etc, however a plugin is suggested (like WPMU Domain Mapping).

    Given that I already have WP 4.4 and WPMU plugin installed and working, how would I remove WPMU Plugin? Would be great if there was a page somewhere with instructions (unless it’s just as simple as deactivating & deleting the plugin).

    Thanks

    Plugin Author Ron Rennick

    (@wpmuguru)

    The text you quoted does not say it’s required

    a plugin is suggested …. (but) You can make the changes directly in the network settings

Viewing 9 replies - 1 through 9 (of 9 total)
  • The topic ‘Update on use of wpdb->escape’ is closed to new replies.