Update to 2.8.0 broke Event post for me

  • Resolved max_Q

    (@max_q)


    10 years, 6 months ago

    The change you made to display_single() in your update to 2.8.0 around line 419 broke the display on single post for me. The test if(is_single() && $current_content==$content) is never true. The problem is $current_content is never == to $content, even with the filter priority at 9999.

    2.8.4 is still broken for me.

    I commented out the if, for now.

    Regards

    https://www.ads-software.com/plugins/event-post/

Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Author Bastien Ho

    (@bastho)

    Hi,

    can you see the difference betweens the 2 variables ?

    Plugin Author Bastien Ho

    (@bastho)

    I’ve changed the test behavior, using get_queried_object() instead of global $post.

    I was think that you maybe redeclare $post somewhere in your page.

    Does it works for you ?

    Thread Starter max_Q

    (@max_q)

    Hi,

    v2.8.6 still doesn’t work for me, but I disabled the other two plugins I have that modify $content, and I’ve narrowed it down to a conflict with a plugin called WP Geo. Since it’s building a Google map to add to $content, maybe it’s output is different each time, causing the test to fail.

    I feel like testing two instances of $content for equivalence is always going to be problematic, and that filter priority of 9999 does mess up the display for me. How about a shortcode or function call in the template?

    I’m using Event Post for it’s add to calendar functionality. I couldn’t get Open Street Map to recognize street addresses in my town.

    Plugin Author Bastien Ho

    (@bastho)

    Hi,
    effectively, a shortcode seems to be the best alternative, in order to prevent other the_content instances to display the event bar.

    It should come relatively soon.

    Thread Starter max_Q

    (@max_q)

    Great. I like it.

    Plugin Author Bastien Ho

    (@bastho)

    You’re welcome

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘Update to 2.8.0 broke Event post for me’ is closed to new replies.