Upgrade Database Hangs

@sevensoutbill – The only way to know what the error is relies on checking your PHP error logs. If you can get those we can hopefully help track it down quickly.

Thanks, will do. I was just hoping someone else ran into this as well and had a quick fix.

Found the errors in our logs. Thoughts?

[Wed Mar 28 09:55:14 2018] [error] [client x.x.x.x] PHP Fatal error: Can’t inherit abstract function PUM_Interface_Batch_Process::process_step() (previously declared abstract in PUM_Abstract_Batch_Process) in /var/www/html/wp-content/plugins/popup-maker/classes/Abstract/Batch/Process.php on line 15, referer: [dev]/wp-admin/update-core.php
[Wed Mar 28 10:05:39 2018] [error] [client x.x.x.x] PHP Fatal error: Can’t inherit abstract function PUM_Interface_Batch_Process::process_step() (previously declared abstract in PUM_Abstract_Batch_Process) in /var/www/html/wp-content/plugins/popup-maker/classes/Abstract/Batch/Process.php on line 15, referer: [dev]/wp-admin/update-core.php
[Wed Mar 28 10:14:10 2018] [error] [client x.x.x.x] PHP Fatal error: Can’t inherit abstract function PUM_Interface_Batch_Process::process_step() (previously declared abstract in PUM_Abstract_Batch_Process) in /var/www/html/wp-content/plugins/popup-maker/classes/Abstract/Batch/Process.php on line 15, referer: [dev]/wp-admin/update-core.php

Here’s what I’m seeing in the console when database upgrade is initiated:

POST [dev]/wp-admin/admin-ajax.php 500 (Internal Server Error)
load-scripts.php?c=1&load[]=jquery-core,jquery-migrate,utils&ver=b67c3e9c43a33019620550d1a9401f48:4

{readyState: 4, getResponseHeader: ?, getAllResponseHeaders: ?, setRequestHeader: ?, overrideMimeType: ?,?…}
admin-batch.min.js?ver=1.7.13:1

XHR failed loading: POST “[dev]/wp-admin/admin-ajax.php”.
load-scripts.php?c=1&load[]=jquery-core,jquery-migrate,utils&ver=b67c3e9c43a33019620550d1a9401f48:4

• This reply was modified 7 years ago by sevensoutbill.

@sevensoutbill – Got that patched just now, thanks for digging into it for us. I can see exactly why that error was thrown now that I’ve looked at the code, but suspiciously its never shown up in my logs which means that it likely is an error related to a very specific version of PHP where you can’t do that, and it has since been changed to allow it. Very strange that nobody else reported it either which further points to that being the case. To be clear we run this on a variety of PHP versions during testing from PHP 5.2.17 through PHP 7.1, but there are so many different versions between and we can’t test them all unfortunately.

The fix is relatively simple if you can edit those files.

Change popup-maker/classes/Abstract/Batch/Process.php:82 from

abstract public function process_step();

to

public function process_step() {
	return 'done';
}

Hope that helps. Let me know. If it doesn’t work right away it may mean there is another error that didn’t show up because this one stopped everything from processing. So bear with me and I will address them as quickly as you report them. Also if your on Facebook join our group and we can conversate in near real time.

Thanks @danieliser. However, that bit of code is already in place at line 82. We are on an older ver of php – 5.3.3. I’ll find you on FB.

Ok – wait a sec. The database upgrade just processed successfully. I think it’s working now. Not sure what just happened.

Haha, ok nevermind. I see there’s a new version with the fix. Thank you!

@sevensoutbill – Awesome! Happy I could help you out. Btw, If you have a moment, I would very much appreciate if you could quickly rate the plugin, just to help us spread the word.