Upgrade from Sugar Calendar 3.0.0 to 3.1.x broke layout
-
In WordPress core as of 5.8.0, the value of
should_load_separate_core_block_assetsis set tofalseby default.In WordPress 5.9.0,
_add_default_theme_supportsadded a filter to setshould_load_separate_core_block_assetstotruefor block themes.In general, by default, from what I can tell, classic themes expect block assets to be loaded together, block themes expect assets to be provided separately. The filter gives us the ability to customize that.
In Sugar Calendar Lite (and Pro) 3.1.0,
should_load_separate_core_block_assetsis filtered totrueas part of the init process for the blocks included with the plugin. This overrides the default decision by core and causes the entire cascade of styles provided by WordPress to change drastically.This change broke the layout on the home page of a client site. We were able to narrow it down and resolve with a new action on
initthat resetsshould_load_separate_core_block_assetsback to its intended value.IMO,
should_load_separate_core_block_assetsis a heavy-handed decision and plugins should not be filtering it for all sites without setting the expectation that a major core default is being changed. Instead, plugins should be able to work around their own cascade issues with separate stylesheets or approaches that may rely on the current value ofshould_load_separate_core_block_assets.Thanks for listening! ??
-
Hey @jeremyfelt,
We confirmed the behavior as described, and we’re going to have this fixed in the next releases.
In the meantime, you can adjust this by adding the following snippet to ensure that the loading of the Sugar Calendar Blocks assets only happens when needed.
if ( ! function_exists( 'sc_separate_core_block_assets' ) ) {
function sc_separate_core_block_assets() {
return false;
}
add_filter( 'should_load_separate_core_block_assets', 'sc_separate_core_block_assets', 100 );
}In case it helps, here’s a tutorial with the most common ways to add custom code like this: https://www.wpbeginner.com/beginners-guide/beginners-guide-to-pasting-snippets-from-the-web-into-wordpress/.
For the most beginner-friendly option in the guide above, I’d recommend using the WPCode plugin: https://www.wpbeginner.com/plugins/how-to-easily-add-custom-code-in-wordpress-without-breaking-your-site/. This will protect your code from updates and keep it easy to manage right within your WordPress admin area.
Thanks once again and have a great one!
- The topic ‘Upgrade from Sugar Calendar 3.0.0 to 3.1.x broke layout’ is closed to new replies.
