upgrading to 2.9 the header-first/header-second throws out display

  • Resolved sarahweb

    (@sarahweb)


    8 years, 10 months ago

    Hi Guido

    not sure why its doing it – but this latest upgrade has thrown out everything layout I use your theme on ?? it looks like its the header-first and header-second is the culprit – went from

    /* HEADER FIRST */
    #header-first {margin:0; padding:0 2% 0; background:none;}
    #header-first:after {content:”; display:block; clear:both;}
    /* HEADER SECOND */
    #header-second {margin:0; padding:0; background:none;}
    #header-second:after {content:”; display:block; clear:both;}

    too

    /* HEADER FIRST */
    #header-first {width:100%; clear:both; float:left; padding:0 2% 0; background:none;}
    /* HEADER SECOND */
    #header-second {width:100%; clear:both; float:left; background:none;}

    and for some reason that means the header-second will never float to the right and header-first to the left – really weird – have downgraded them until I can sort out why – its puzzling me at the moment – not even sure if that is the issue either!

    Anyway just letting you know ?? Still a great theme this one just threw me a curve ball!

    Thanks
    Sarah

Viewing 4 replies - 1 through 4 (of 4 total)
  • Theme Author Guido

    (@guido07111975)

    Hi Sarah,

    I’m sorry but yes I did made some changes, regarding several floating elements. When an element has a width of 100% I don’t need an :after but simply float it to the left side. More info here.

    Did a new update today, header first and second will stay:

    #header-first {width:100%; clear:both; float:left; padding:0 2% 0; background:none;}
#header-second {width:100%; clear:both; float:left; background:none;}

    My question to you, what should be changed in your site? You can also send me a PM via my website.

    Guido

    Thread Starter sarahweb

    (@sarahweb)

    Guido

    Thank you for your reply sent you a message on your website – upgraded and still happening I just cannot seem to float header-first to left and header-second alongside it to the right – so they are next to each other

    I want this
    * header-first * * header-second *

    I get this
    * header-first *
    * header-second *

    Cannot see where I am going wrong!
    Thank you
    Sarah

    Theme Author Guido

    (@guido07111975)

    Hi Sarah,

    I’ve send you 2 mails but will add my code here too, in order to display #header-first and #header-second next to each other in stead of underneath each other:

    #header-first {width:30%; clear:none; float:left; padding:0;}
#header-second {width:70%; clear:none; float:right;}

/* MOBILE */
@media screen and (max-width:767px) {
#header-first {width:100%; clear:both; float:left; padding:0;}
#header-second {width:100%; clear:both; float:left;}
}

    Guido

    ps. this solution is based on most recent version of GridBulletin (did make some changes in last versions of my themes, as you know)

    Thread Starter sarahweb

    (@sarahweb)

    Guido

    it worked perfectly – thank you! I need to dig into why mine didn’t work – but thanks – much appreciated!

    Thanks
    Sarah

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘upgrading to 2.9 the header-first/header-second throws out display’ is closed to new replies.