Upsells show on checkout but not in cart

  • Resolved robwent

    (@robwent)


    2 years, 1 month ago

    Hi,

    This is directly related to another closed thread: https://www.ads-software.com/support/topic/upsell-wont-show-in-cart-but-shows-in-checkout/

    I’ve just spent quite a while debugging this and I’m very surprised to see that this might be the intended behaviour.

    Firstly, when the modal cart is disabled, a load of other options are removed since they are not needed, but the main option to show upsells on the cart page remains and can be toggled on and off.
    If it isn’t possible, then why leave that option there?

    When I check the source of the cart page, I see the placeholder for the items and it shows up in the correct place according to the admin settings.
    <div class=”wc-timeline-cart-upsell”></div>
    But the fragment to add the content only shows when the modal cart is enabled.

    I see in app/WooActions.php:537 that there is a check to see if we are on the cart page already. So it seems an odd decision if this is intentional as I would have thought that the checks and output would almost be identical to the output for the checkout page.

    So is this really intentional?

    Regards,

    Rob

Viewing 5 replies - 1 through 5 (of 5 total)
  • Plugin Author Giacomo

    (@jakjako)

    Hello robwent, and sorry for this issue!
    No, it’s not intentional: cart page upsell was added months after the background mode and we probably forgot to exclude that from that check.

    Next version will have this bug fixed!

    Thread Starter robwent

    (@robwent)

    That’s great news!

    I also tried keeping the cart on and disabling the open cart on add product option, but it opened anyway. That might be something to do with our theme though (Which also has a similar cart built-in).

    Do you have an idea how long it will be until the next release?

    Thanks again.

    Rob

    Plugin Author Giacomo

    (@jakjako)

    Tomorrow probably ??

    Thread Starter robwent

    (@robwent)

    Great news!

    Plugin Author Giacomo

    (@jakjako)

    Hi @robwent, unfortunately we can’t update the plugin this weekend.
    If you want to change that manually, in the meanwhile, you can move this:
    WooActions.php – Line 50
    add_filter( ‘woocommerce_add_to_cart_fragments’, array( $page, ‘wc_timeline_fragments’ ) );

    outside of the brackets (for example at line 54 or 55). That’s all you need to do ??

    The next update will contain this change, so don’t worry about updates!

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘Upsells show on checkout but not in cart’ is closed to new replies.