Use plugin on a custom role but limit on shopmanager

Hi @tanasi

Thank you! And yes, this is definitely possible.
In fact, it’s always recommended to limit the capabilities if you are allowing users to create/edit users.

Luckily, WordPress core has a built-in filter for this: editable_roles: https://developer.www.ads-software.com/reference/hooks/editable_roles/

Example (see also level_# example in doc page above):

add_filter( 'editable_roles', function( $roles ) {
    $user = wp_get_current_user();

    // Define your logic to enable/disable role edits for the current user.
    // For example:
    if ( in_array( 'seller', $user->roles ) ) {
        $roles = [ 'subscriber', 'editor' ]; // Only allow viewing subscriber and editor.
    }
    
    return $roles;
} );

Note that some plugins allow you to add multiple roles to a user, this will require you to improve the code above to validate all the user roles instead of just one.

Hope this helps!

Cheers, Jory

Hi,

thanks for the detailed reply.

I tried your example but I don’t get to make it work.

I have deactivated all plugins, activated the base theme, put the code to the functions.php, but the seller role still can see and switch as shop manager.

I have tried also to set the seller role as level_0 and the put the shopmanager as level_5 and use the respective code from the link https://developer.www.ads-software.com/reference/hooks/editable_roles/
but no luck.

Any ideas on what else I can try?

Hi @tanasi

Sorry, I always forget to mention that filters made for this plugin should be added as a plugin or even better, as a mu-plugin. With the latter you can just put the same code in a PHP file and put it a /wp-content/mu-plugins.

Since the code for VAA runs so early, adding it in your theme will be to late as all validations have run already.

It might be a nice addon to the plugin to be able to edit them using the UI.

Cheers, Jory

Hmm I tried your suggestion but I can’t make it work.

I have tried both in plain plugin and in mu-plugin as you suggested.

In that plugin I have added the code you provided and also added another code to show a text in the footer so that I know that my plugin is active and working.

The seller role can still switch to shopmanager role.

I have also tried to recreate that in a clean environment with only woocommerce and VAA and still the seller can switch.

Any ideas?

(I can provide creds if you like to check it)

Could you share the code you’ve used in your mu-plugin?

Creds are not allowed to be shared through the forums.

Cheers, Jory

The code is:

add_filter( 'editable_roles', function( $roles ) {
    $user = wp_get_current_user();

    // Define your logic to enable/disable role edits for the current user.
    // For example:
    if ( in_array( 'seller', $user->roles ) ) {
        $roles = [ 'subscriber', 'editor' ]; // Only allow viewing subscriber and editor.
    }
    
    return $roles;
} );

Hi @tanasi

Ah you’ve just copied the code. Please make sure that the names for these roles are 100% correct. I’ve written them based on your writings but it could well be that the internal name is different.

Edit: You did add a <php to the file right? And I also see an HTML entity in your copied code. The code was meant as an example, you should changed it to match your actual installation.

Also, note that your need to login as a Seller role user in order to see the changes in your View Admin As menu.

Cheers, Jory

• This reply was modified 6 months, 3 weeks ago by Jory Hogeveen.

Hi @tanasi

I also just noticed an issue with my code, apparently the roles are set as the array keys.
New code (this time the php prefix)

<?php
add_filter( 'editable_roles', function( $roles ) {
	$user = wp_get_current_user();
	$editable_roles = [];

	// Define your logic to enable/disable role edits for the current user.
	// For example:
	if ( in_array( 'seller', $user->roles ) ) {
		$editable_roles = [ 'subscriber', 'editor' ]; // Only allow viewing subscriber and editor.
	}

	if ( $editable_roles ) {
		return array_intersect_key( $roles, array_flip( $editable_roles ) );
	}

	return $roles;
} );

Hope this helps!

Cheers, Jory

Hi Jory,

this seems to work great now!!

Yes I did as you said before (correct names, php at the beginning etc) but something was missing I guess.

Keep up the good work.. Your plugin is amazing ??