Username in email picks up different user

good day @junglist2018

Is it just in the email? or is it showing through with their user profiles inside of WP/BuddyPress areas as well?

Was this from approving a single user at a time, or did you see the issue with bulk approval?

Thanks for getting back to me. It’s just in the email however it has only happened to a couple of users not everyone. So sometimes the emails are correct and sometimes not.

Not sure if they were bulk approved or not but I’m assuming not as registrations came in at different times and individually so would have to check with my developer.

Have you seen this problem with bulk approvals before?

Cheers

Overall no not really. We’ve had a really recent similar report but I wasn’t able to reproduce. Any previous issues had either gone unnoticed or unreported.

Any information you could provide to help me try to recreate the environment and state of a given website would be beneficial.

I had this same problem happen to me. A newly approved user showed me the Approved email they received on their email address but it showed the username for another user. They were one of 3-4 users that I approved at the same time [Bulk] option in the Member Requests page.

Overall, I can’t say how much I appreciate this plugin in being able to approve accounts on our site! For now, I will approve users one by one.

• This reply was modified 6 years, 8 months ago by chaosbuster.

I can try again to recreate the issue, but last time I wasn’t managing to.

Managed to recreate finally, or realize that I was able to, consistently, so investigating.

Thank you, Michael, to your dedication and efforts to repeat!

So, as it turns out, due to multiple users being approved at the same time, the “approved message” option was losing the placeholders after the first iteration. I was not re-setting some code back to the default value. Because of this, on the 2nd pass and upwards, the placeholder replacement was not succeeding, and was retaining the replaced values from the first moderated user.

I have slated a fix for this to be part of version 4.3.4, but at the same time, I have a list of other things I’d like to get officially taken care of in 4.3.4 as well, so I’m not releasing officially quite yet.

However, I have provided a copy with just this one fix in place, for anyone here to use for the moment. It should be fully ready to install, but it will still show a version number of 4.3.3 at the moment.

https://www.dropbox.com/s/m2zkw75uum5kwum/bp-registration-options-hotfix.zip?dl=0

If you’re willing to attempt to read some code, here’s what got changed: https://github.com/WebDevStudios/BuddyPress-Registration-Options/commit/54755c0d89539cde297e582712cfc6ab6fb8d4c1

Lines in red are the old value, lines in green are the new value. Line 222 is the important one, because that’s where we re-set $message back to the default version with the [user_name], etc values to be dynamically replaced.