Using in-house/custom Analytics causes JavaScript Errors

For example, this code works 100% fine, and tracks 100% fine, except the plugin is adding that type field (as above) which throws the error.

{
    "triggers": {
        "trackPageview": {
            "on": "visible",
            "request": "pageview"
        }
    },
    "transport": {
    	"beacon": false,
    	"xhrpost": false,
    	"image": true
    },
    "requests": {
        "base": "https://site.com/path/to/analytics/pixel.gif&rnd=${random}",
        "pageview": "${base}"
    }
}

So the issue is that the “Type” input should be allowed to be empty, correct?

As an alternative to using the Analytics screen to provide this configuration, you can instead use plugin code to do the same:

$print_inhouse_analytics = function () {
	?>
	<amp-analytics id="inHouseAnalytics">
		<script type="application/json">
			{
				"triggers": {
					"trackPageview": {
						"on": "visible",
						"request": "pageview"
					}
				},
				"transport": {
					"beacon": false,
					"xhrpost": false,
					"image": true
				},
				"requests": {
					"base": "https://site.com/path/to/analytics/pixel.gif&rnd=${random}",
					"pageview": "${base}"
				}
			}
		</script>
	</amp-analytics>
	<?php
};

add_action( 'wp_footer', $print_inhouse_analytics );

// For classic reader mode templates.
add_action( 'amp_post_template_footer', $print_inhouse_analytics );

• This reply was modified 4 years, 9 months ago by Weston Ruter.

Nevertheless, I’m seeing this as an issue when attempting to paste the amp-analytics tag onto https://playground.amp.dev/

Inline or remote config should not overwrite vendor transport settings

The transport config is causing a problem here, but I don’t know why.

This appears rather to be a general AMP issue and not specific to the AMP plugin (other than the issue requiring a type), so therefore I recommend opening an issue on the AMP GitHub repo, as I’m not an expert on the amp-analytics component: https://github.com/ampproject/amphtml/issues

I did open a PR to eliminate the type requirement: https://github.com/ampproject/amp-wp/pull/4802

Thanks @westonruter.

I think this behavior is intentional to AMP (at least from my research this morning).

If you specify a type then it presumes you’re using a vendor definition and, when you’re using a vendor definition, the transport should be defined by the analytics vendor and not overridden by the publisher.

It would be possible, for example, for a vendor to only support GET requests, and then a publisher attempts to override that with a transport method that uses POST request and now thing are broken, hence the error. (Honestly I think it should be a warning and not an error, but, hey, the internet exists for opinions, right? ??

With type absent, it knows you’re not using a vendor definition and transport is an acceptable thing to define.

I’m seeing the same console error both with and without the type attribute (including a type attribute that has no value).

AHh, rats. That’ll teach me to believe what I intuit when reading the AMP developers talking on their threads. ??

FYI: The ability to omit the type will be part of v2.0 which is due out this month.