Using Woocommerce default styling and markup

  • Hi,

    By using native Woocommerce functions for notices and HTML markup for tables we don’t need to incorperate new styling.

    Like “.woocommerce table.shop_table”, so we add “shop table” to the “#wcssc-saved-cart-table” table.

    I can’t build this and open a Pull Request for you, already have one ready here locally for using the Woocommerce notices output.

    Kinds regards,

    Jaime!

Viewing 8 replies - 1 through 8 (of 8 total)
  • Thread Starter jmslbam

    (@jmslbam)

    Ah, I see you already doing it at single-saved-cart.php, but not yet on template-saved-carts.php.

    Ciao!

    Plugin Author Ankit Gade

    (@wpgurudev)

    Hi,

    Thanks for your suggestions and help.

    Could you please let me know if you can create a PR at: https://bitbucket.org/ankitgade/woo-save-share-cart ?

    I have made the repository public and you should be able to create the PR now.

    Regards,
    AG

    Thread Starter jmslbam

    (@jmslbam)

    I see a bit more options, but no options to Fork it. Without a Fork I can’t open a PR. I found the settings a “settings > repository detail > forking dropdown”.

    You have that option also?

    Plugin Author Ankit Gade

    (@wpgurudev)

    Hi,

    I don’t see that option available for me.

    Do you want me to put the repo in GitHub? I can create a mirror over there so that you can create a PR.

    Regards,

    Thread Starter jmslbam

    (@jmslbam)

    Unfortunately. If you could do that, that would be great!

    Last week I added an extra “remote” remote to my original repo so I wouldn’t have to push to it individualy. I think I used this article to set it up. https://gist.github.com/rvl/c3f156e117e22a25f242

    Ciao and thank you for taking the time!

    Thread Starter jmslbam

    (@jmslbam)

    By the way, the WooCommerce way to add a notice is via wc_add_notice( __( 'Cart removed successfully.', 'wcssc' ), 'success' );

    and a wc_print_notices(); in the template file.

    Hope I can start contributing to this plugin with some PR’s, kind regards!

    • This reply was modified 4 years, 9 months ago by jmslbam.
    Thread Starter jmslbam

    (@jmslbam)

    Maybe it’s an option to switch to GitHub, I have noticed that it’s a bit more developer friendly then BitBucket.

    Plugin Author Ankit Gade

    (@wpgurudev)

    Hi Jaime,

    I have moved the plugin repo to github from bitbucket.

    https://github.com/ankitrox/woo-save-share-cart

    Sorry for the delay, I remember having a discussion about moving the repo to github so that you can create the PR here.

    Regards,
    Ankit G.

Viewing 8 replies - 1 through 8 (of 8 total)
  • The topic ‘Using Woocommerce default styling and markup’ is closed to new replies.