• Resolved mddsharpp

    (@mddsharpp)


    Hey @westonruter

    I just installed version 1.0 RC2 on the latest WordPress and Colormag theme on a stage and 1 article for testing.

    Running external AMP validation shows valid AMP and good structured data but internally it says there are 13 errors. I am running in paired mode.

    Here are the errors

    Here is the URL

    Let me know if I can do anything for testing.

Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Author Weston Ruter

    (@westonruter)

    @mddsharpp Thanks a lot for testing.

    The errors that are being reported are those which have been caught. Notice that the my are all shown as being “new accepted”. That means that the plugin is sanitizing them (that is, removing them). Because of the sanitization, the AMP validator reports that it is valid, because the plugin makes it valid. And that is working exactly as intended.

    So it is expected that you evaluate those validation errors reported, and if they are truly all OK to be sanitized, then you can mark them as Accepted to clear their “new” state. This will Mark the errors as acknowledged and you won’t get complaints about them anymore. If the theme then looks right style-wise and there isn’t any critical JS being removed (e.g. for ads or analytics) then you’re done! In general any theme should behave in AMP by default as if JS is disabled in the browser, since all custom JS is removed. So if the theme gracefully degrades for noscript visitors, as good themes should, then the paired mode should get you a great AMP version out of the box.

    Plugin Author Weston Ruter

    (@westonruter)

    Aside: 1.0-RC3 was released a couple days ago.

    Thread Starter mddsharpp

    (@mddsharpp)

    OK, I clicked on the link from another support question where you sent me to RC2 a week ago. You have the RC3 link?

    I can report RC2 sanitizes, validates, passes mobile and structured data testing. Comments are in AMP pages, categories and pages work as well. And related posts work.

    All this on Colormag. Thank you from getting me away from that other shady AMP plugin!

    Plugin Author Weston Ruter

    (@westonruter)

    Thread Starter mddsharpp

    (@mddsharpp)

    Do you want RC3 issues that show up to come here or Github?

    Plugin Author Weston Ruter

    (@westonruter)

    GitHub would be best. Thanks.

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘V1 RC2 on Colormag Theme’ is closed to new replies.