v2.1.0 No Longer Loads Custom Theme

  • Resolved spherical

    (@spherical)


    7 years, 3 months ago

    For my non-WordPress coding I use Notepad++. It has a theme that is colors/black on white background. Gotten very used to it and there’s nothing even close in the default themes, so I created a custom CSS section a few versions back and added it to the plugin CSS files, then added a corresponding title of my theme to css.json. Versions up to 2.0.1 have worked fine.

    Debugging, I used Notepad++ Compare to check for diffs. Most were in .js files. Then began swapping out files between the two versions to see what may let my theme display again. Turns out that only loading the v2.0.1 html-editor-syntax-highlighter.php, with the v2.1.0 files in /dist, allows it to work.

    However, the only diffs between the two php files are the four version lines in the header comment section. Nothing in the running code outside the comment is different.

    Well, that’s interesting. So, I altered the commented line:

    * Version: 2.1.0

    to:

    * Version: 2.0.1

    and it works. Altered the line to:

    * Version: 2.1

    and it works. For some reason, the code doesn’t like ‘2.1.0’. Huh?

    • This topic was modified 7 years, 3 months ago by spherical.
Viewing 1 replies (of 1 total)
  • Plugin Author James Bradford

    (@arniebradfo)

    I’m not sure whats going on here, but changing the version in the comment header shouldn’t do anything. So I guess the code would be indifferent to ‘2.1.0’ if were putting this in terms of how the code feels. ??

    I just pushed another update that will change things for you again if you are trying to use a custom theme. css.json is gone now.

    There is an array at the very bottom of the .php file that has all the themes. Add your theme name there.

    You’ll also need to add a line to hesh_admin_enqueue_scripts to enquque the theme’s css file’s loading:
    wp_enqueue_style( 'customcss', HESH_LIBS.'your-css-file.css', false, $ver );

    Lastly, add your file to the dist folder, and you should be golden.

    I’ve added a ‘Default’ theme to the list that sounds a lot like what you want. So maybe you can skip your custom theme. I’ve also added a ‘None’ option if your after just the plain black & white.

    Let me know if you’ve any questions. I’m happy to help.

    -James

Viewing 1 replies (of 1 total)
  • The topic ‘v2.1.0 No Longer Loads Custom Theme’ is closed to new replies.