v2.5.1 BREAKS approvals and BBPress

Hi @reelscene,

Based on those error messages, it sounds like the core Paid Memberships Pro plugin may not have been enabled on your site when those errors were thrown. Can you please ensure that the core Paid Memberships Pro plugin is active on your site and then check whether those error messages are still being shown?

That’s odd, I used the WordPress admin to upgrade. However, upgrading manually by uploading the zip file and extracting into plugins/ did the trick, thanks for the response ??

We looked into the specific errors and line numbers you shared. We would want those plugins to check first if PMPro is active before trying to use PMPro functions.

In the case of the Approval plugin, that line number is in the isApproved method, which doesn’t check if PMPro is active, but in practice should only be called on a member or when PMPro is active. This makes me think that you might have custom code calling the PMProAPprovals:isApproved method. If so, you would want to wrap THAT code in a check.

In the case of the bbPress plugin, we are already checking for the PMPRO_VERSION constant, which should avoid that error. https://github.com/strangerstudios/pmpro-bbpress/blob/dev/pmpro-bbpress.php#L33-L43

This makes me think that maybe you were using a different version of that plugin or some other custom code that is resetting the PMPRO_VERSION constant.

This is all just FYI in case something comes up again.

Thanks for looking into that. I am using the Aardvark theme which includes bbpress and PMPro but I haven’t got any Approvals-specific code. I was having some resource issues on the server and 503 errors so it’s possible the plugin update didn’t complete properly. For the next update I’ll keep track of everything that happens more clearly if there’s an issue, cheers!