Very nice

Hi Johan,

Thanks for your suggestions with the plugin. I’d just like to address some of your concerns.

In regards to user permissions, the editor should only be available to users with the ‘create_users’ permission. By default this would of course only apply to admins. If you have altered the permission structure in any way, this would present an issue here. I can’t imagine any other reason it would show up for non-admin installs on your setup but I would be very interested on sorting this out if it is in fact an issue.

The disappearing of the dashboard left panel is a feature inherited from WPide and was never a feature I was ever too fond of – however I can see its value for other users. There is currently a filter to disable it however I am working on a settings menu that will have the option in a simple checkbox.

Back when WPide was under active development, I submitted a large patch containing a filter for changing the root editor path – again, this will become a setting when the settings page is generated. Until then, you can modify the ‘aceide_filesystem_root’ filter to the value of your desired root path to achieve this functionality.

In regards to the UI issue with the find dialog… That’s curious. I’m not 100% sure what exactly you’re saying the issue is but it sounds like some inputs are flowing out of the find dialog and are being hidden? What browser/os are you using? Could you provide a screenshot please?

Opening of files and folders is done over an AJAX request. This means that everything to do with an HTTP request can slow down opening of these directories and files. I notice no real issues here on full WordPress installations. How long is your delay? Is it possible that it is spending a long time on data transit or on processing other places in WordPress? Or that it may be another server-related issue?

A progress bar would definitely be a great feature however (as far as I am aware) there is no actual way to get progress information out of the zipping library. However, I am yet to properly investigate this.

Monokai is an ace theme? I am not familiar with it. I will also be providing an option to change the theme in the settings page.

I look forward to hearing back from you on these points.

Kind Regards,
Shane

Hi Shane.

1. user permissions
I understand, i have altered user permissions for years now. We the builders make websites for clients. And clients (editors) are able to add non-admin users. That is how it goes for our business, and for other firms i know. I guess it would be stronger for the plugin to rely on something else that ‘create_users’.

2. Disappearing of the dashboard
Not too fond of it either. I believe the future option should make it disappear if checked. Not the opposite. It does sound ‘gadget’.

3. Change root to current theme
OK

4. Find dialog
I’m on Chrome/Win7, and same result with Firefox. I’ve put my windows display of text settings back at 100%, and i get the same result. Here is a screenshot:
Screenshot

5. Opening folders is rather slow
I understand… i guess it is stronger to make an ajax new call every time so it acts like a refresh also. Css transition could be a bit faster…but this is not an issue.

6. Zipping progress bar
I’ve never tried a zipping library so i can’t be of any help right now.

7. Monokai
Yes it is an ace theme… or THE ace theme :). Anyway it can be changed already in the actual settings lightbox as ‘ace/theme/monokai’. I just meant that it would be more sexy to have it selected by default.

Thanx for the pretty complete reply…

Johan

• This reply was modified 7 years, 11 months ago by jDelforge.

Thanks for getting back to me Johan.

1. I’ve had a look at the history of the project to figure out why the ‘create_users’ capability was selected. I can not see any reason why it should not be a more appropriate capability such as ‘edit_themes’. I will create an issue in the github tracker for this and get it ammended in the next release which should be within the week.

2. I feel a bit between a rock and a hard place on this one. From one aspect, I’d like people to specifically select to use customisations such as this one. However I don’t want to be constantly changing the ‘default’ (and therefore expected) behaviour of the plugin. So I’m a bit unsure as to what to do with this one. I will have to make a decision before I release the settings manager however, and make the change with the new panel.

4. I see the issue there – simply that it’s a different language to that of which I have developed with, so it’s pushing everything down. This is great – that you have shown me this at least, I am sorry that it’s proving to be an issue for you. I will get to work on this as soon as I can.

7. I’ll have a look at Monokai and if I think it would be better than the current theme, I will definitely switch it. However this is in the same context as the 2nd point to me, on changing default behaviours. I hope you can appreciate my reasoning behind this?

Thank you for all of these points, I deeply appreciate all your suggestions and tips to make the plugin better.

Kind Regards,
Shane