• Resolved Adam

    (@damilchr3278)


    Hi.
    Many thanks for an excellent plugin. One thing I’ve noticed is that every time it updates to a new version the setting “Whitelist of country code” on the Settings tab has US added to it. I have it set as GB, every time it’s updated it becomes GB,US (and the Americans start trying to hack it!)

Viewing 8 replies - 1 through 8 (of 8 total)
  • Plugin Author tokkonopapa

    (@tokkonopapa)

    Hi damilchr3278,

    Thank you for your reporting this issue. In the past, the similar issue was reported in “GB added to whitelist” and I believed it was fixed. But still it seems to stay there.

    Actually, every time you activate or update this plugin, the country code in whitelist will be updated because of <a href=”https://www.ipgeoblock.com/codex/what-should-i-do-when-i-m-locked-out.html&#8221; title=”
    What should I do when I’m locked out?”>Emergent Functionality. But its algorithms should be improved.

    Now I start to investigate this issue again. I hope I can fix it in near future.
    Thank you for your cooperation in the improvement of this plugin.

    Plugin Author tokkonopapa

    (@tokkonopapa)

    Hi damilchr3278,

    I’ve been checking the logical design and code for these 2 days, but I could not find the cause.

    This could be happened when:

    1. You set the wrong country code as whitelist. For example, your country code is “US“, but you set “GB
    2. You force to logout. Then you will be locked out.
    3. So you delete this plugin by using FTP or file manager such as cPanel.
    4. And you re-install this plugin and activate it again.
    5. Then this plugin automatically add the correct country code, e.g. “GB,US“.

    This process is described at “What should I do when I’m locked out?“.

    And actually, the same process will run when you activate or update this plugin.

    So could you try to once deactivate this plugin and activate again? If this issue always happens in your site, I can find the path to resolve the issue.

    I’d appreciate your cooperation.
    Thanks.

    Thread Starter Adam

    (@damilchr3278)

    Hi.

    Thanks for your reply. On the first points, the country code is set correctly, I haven’t been locked out, and I haven’t changed any files / re-installed etc.

    I’ve just deactivated and reactivated the plugin (on 2 different sites), and the country code is staying correctly set.

    I’ve just tried something else, and think I might have found the culprit. I use infinitewp to manage my websites – deactivating and reactivating it from there causes the country code to be set incorrectly. There must be something different about the way it activates plugins.

    Many thanks.

    Plugin Author tokkonopapa

    (@tokkonopapa)

    Hi,

    Thank you for your investigation. Then your server might be placed in the different country from you as a client, and InfiniteWP is installed in the server. It makes sense.

    Every time you update my plugin, you’ll feel inconvenient because you should correct the country code on every site.

    One solution is to put your server’s IP address into “Whitelist of extra IP addresses prior to country code” at “Validation rule settings“, but I don’t recommend it because some attackers potentially have the same IP.

    Another solution is implementing a special action filter or an option to inhibit resetting the country code or to set the fixed county code on updating.

    Well anyway, I think your case is not so special. So I’d think about something. If you have any good ideas, please let me know. I keep this thread open until we get the solution.

    Thanks for your cooperation!

    Thread Starter Adam

    (@damilchr3278)

    Many thanks, that’ll be the case – InfiniteWP is on a server in the US. I’ll update the plugins manually, which in the scheme of things is no great inconvenience!

    Plugin Author tokkonopapa

    (@tokkonopapa)

    Dear @damilchr3278 and all,

    I improved the behavior of this plugin related to this issue so as to avoid resetting country code on update.

    If you still find any issues in version 2.2.8.2, please let me know.

    Thanks.

    Thread Starter Adam

    (@damilchr3278)

    It’s still doing it, I’m afraid!

    I’m quite happy resetting it after each update, now that I know why it’s doing it.

    Thanks.

    Plugin Author tokkonopapa

    (@tokkonopapa)

    I appreciate your kind understanding. I thing I might overlook something. So I’d keep to try finding the solution of this issue.

    Thanks for your reporting again!

    • This reply was modified 8 years, 5 months ago by tokkonopapa.
Viewing 8 replies - 1 through 8 (of 8 total)
  • The topic ‘Whitelist resets on update’ is closed to new replies.