Why add “?” when permalink_structure empty

  • Resolved alhrath

    (@alhrath)


    2 years, 3 months ago

    Hi,

    Just out of curiosity, why do you automatically add a “?” in the login url when the permalink_structure option is empty ?

    It seems to me that it can add confusion, if someone change the permalink settings, the login url will be changed as well without warning …

    Best,
    Alhrath

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Support MaximeWPS

    (@seinomedia)

    Hello,

    Thanks for using WPS Hide Login.

    What do you mean ? The login and 404 values in WPS Hide Login settings can’t be empty. There are default values which don’t contain any ?

    Thread Starter alhrath

    (@alhrath)

    No I mean if the wordpress core permalink setting is set to null (corresponding to “plain” in Settings->Permalinks), your plugin add a question mark before the login url slug. I think this is done in the new_login_url function in wps-hide-login/classes/plugin.php :

    
if ( get_option( 'permalink_structure' ) ) {

                        return $this->user_trailingslashit( $url . $this->new_login_slug() );

                } else {

                        return $url . '?' . $this->new_login_slug();

                }

    I was just wondering if there is a reason to that.

    • This reply was modified 2 years, 3 months ago by alhrath.
    • This reply was modified 2 years, 3 months ago by alhrath.
    • This reply was modified 2 years, 3 months ago by alhrath.
    Plugin Support MaximeWPS

    (@seinomedia)

    Hello,

    Ah ok !

    Yes, it’s the way the plugin works. plain permalinks setting + WPS Hide Login = /?secret-slug.

    No worry about that ??

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Why add “?” when permalink_structure empty’ is closed to new replies.