why does it rewrite wp_authenticate?

  • Resolved stankea

    (@stankea)


    7 years, 11 months ago

    Hi,

    Why does this plugin rewrite wp_authenticate rather than just use the authenticate filter?

    Rewriting the wp_authenticate looses the compatibility with any other plugin which depends on it – in my case, jetpack.

Viewing 8 replies - 1 through 8 (of 8 total)
  • Plugin Author Paul Gilzow

    (@gilzow)

    because it was written at a time when pluggables.php was the only method and I just haven’t had time to go back and rewrite it. ??

    • This reply was modified 7 years, 11 months ago by Paul Gilzow. Reason: Words
    Thread Starter stankea

    (@stankea)

    Ok, makes sense ??
    I’ll see if i can find some time to hook it up to authenticate filter rather than rewriting the wp_authenticate. I’ll post here if you’re interested, or let me know if you have it on the nearest TODO list then i’ll just wait ??

    Plugin Author Paul Gilzow

    (@gilzow)

    it’s on the TODO list. I just have to stop speaking at so many WordCamps!

    Actually, I have another plugin I’m writing where the two are both going to need to work in concert, so I have a *need* for it to hook into the authenticate filter.

    Plugin Author Paul Gilzow

    (@gilzow)

    had some time today and while it’s not the complete overhaul i want to do, it at least now defaults to using the authenticate filter, and then falls back to pluggable if the WordPress version is super old.

    Want to test the new version for me and see if it works in your situation?

    https://gist.github.com/gilzow/ea6b0d148757bdeff25c0e1f7b60fcb5

    Thread Starter stankea

    (@stankea)

    Hi,

    Did a quick test on my blog and it worked fine. Was able to connect jetpack without issues (had to disconnect and connect JP again to get it working properly).

    Thanks, hope it gets polished and released soon, as i don’t like running local mods ??

    Plugin Author Paul Gilzow

    (@gilzow)

    Just need to test it in a multi site, then I’ll push it out. Should hopefully happen later today.

    Thread Starter stankea

    (@stankea)

    my setup is a multisite by the way

    Plugin Author Paul Gilzow

    (@gilzow)

    I’m going to go ahead and mark this one as resolved as I pushed the changes out in v1.8.0. If 1.8.0 didn’t fix things, let me know and I’ll reopen.

Viewing 8 replies - 1 through 8 (of 8 total)
  • The topic ‘why does it rewrite wp_authenticate?’ is closed to new replies.