Width Not Quite Right

  • Resolved fourlightsweb

    (@fourlightsweb)


    7 years, 10 months ago

    I like this plugin, it’s very handy! I noticed while working on a layout recently that my edges for 1/3 and 2/3 weren’t lining up with the full width of the container. I looked at the plugin’s css, and saw that for 2/3 it had a width of 63.2478632479%. I checked an old version of Genesis that still had the column css in it, plus the current documentation for column classes on studiopress.com (https://my.studiopress.com/docs/content-column-classes/ if you can log in), and both had a value of 65.81196581196582% for 2/3. I’m not sure if the plugin’s css is a typo, or old code, or maybe the discrepancy is intentional, but I just wanted to bring it to your intention (there are a few others like this as well). I overwrote the css with the old Genesis versions for a simple fix, so I’m not in immediate need of help, just wanted to let you know. ??

Viewing 7 replies - 1 through 7 (of 7 total)
  • Plugin Author Nick Diego

    (@ndiego)

    Hi fourlightsweb, thanks for spotting this. Very much a bug. I will get this resolved by tomorrow.

    You mentioned “there are a few others like this as well”. Do you mind sharing. It would be nice to tackle everything at one.

    Thanks,
    Nick

    Thread Starter fourlightsweb

    (@fourlightsweb)

    At this risk of missing something and/or typoing, here is studiopress’s “add this to your css” list:

    /* Column Classes
    Link: https://twitter.github.io/bootstrap/assets/css/bootstrap-responsive.css
--------------------------------------------- */

.five-sixths,
.four-sixths,
.one-fourth,
.one-half,
.one-sixth,
.one-third,
.three-fourths,
.three-sixths,
.two-fourths,
.two-sixths,
.two-thirds {
	float: left;
	margin-left: 2.564102564102564%;
}

.one-half,
.three-sixths,
.two-fourths {
	width: 48.717948717948715%;
}

.one-third,
.two-sixths {
	width: 31.623931623931625%;
}

.four-sixths,
.two-thirds {
	width: 65.81196581196582%;
}

.one-fourth {
	width: 23.076923076923077%;
}

.three-fourths {
	width: 74.35897435897436%;
}

.one-sixth {
	width: 14.52991452991453%;
}

.five-sixths {
	width: 82.90598290598291%;
}

.first {
	clear: both;
	margin-left: 0;
}

    I’d probably just copy/paste those width values into the plugin’s css, since you can see how some of them are off by ~2%, and some of them have rounded percentages, etc.

    Thread Starter fourlightsweb

    (@fourlightsweb)

    I guess your plugin has fifths, I leave that up to you ??

    Thread Starter fourlightsweb

    (@fourlightsweb)

    Ultimately, it looks like the 2/3 width is calculated in your plugin by adding two 1/3 together, but is missing the middle margin ~2.5% that would also be in between two 1/3 to make up a 2/3-sized block – not sure if that’s factored into the others.

    Plugin Author Nick Diego

    (@ndiego)

    Yup, that is it! I have a generator that auto built these and it didn’t carry the additional margin widths!!! I will get this fixed and an update pushed this evening. Surprised no one else caught this. I really appreciate it.

    I will post again once the update is live.

    Nick

    Plugin Author Nick Diego

    (@ndiego)

    All updated and version 2.0.3 is available to download! Thanks for your help on this!

    Nick

    Thread Starter fourlightsweb

    (@fourlightsweb)

    Thanks for the speedy response! ??

Viewing 7 replies - 1 through 7 (of 7 total)
  • The topic ‘Width Not Quite Right’ is closed to new replies.