Viewing 9 replies - 1 through 9 (of 9 total)
  • Plugin Support Georgi Ganchev

    (@georgiganchev)

    Hello @roberthemsing,

    I watched the video and noticed the issue. As explained in the articles you mentioned, not all combined files are listed in the exclude options within SiteGround Optimizer. This usually happens when the JS is custom and cannot be detected successfully.

    For such scenarios, Elena has already provided you with a filter that you can use to exclude additional script handlers. She also provided you with the ones she had found at that time. The topic was opened more than a year and four months ago so the handlers may have changed during that period.

    You can consult with your developer and find the proper script handlers that you can exclude within the functions.php of your theme. This will stop the issue from occurring.

    The alternative is to keep the combine JavaScript option disabled and still benefit from the other functionalities of the SiteGround Optimizer.

    Best regards,
    Georgi Ganchev
    SiteGround.com

    Thread Starter Rosso Digital

    (@roberthemsing)

    Hi @georgiganchev – I’m actually quite disappointed by your response. We love Siteground and actually on-sell it to our clients. Square is one of the fastest growing payment providers globally (which has been confirmed by WooCommerce and they’ve named Square one of their authorised payment plugins) and WooCommerce itself is *the* main eCommerce platform for WordPress. There is no custom coding applied to the plugin – it’s out of the box straight from WooCommerce.

    I’m surprised that Siteground hasn’t got the slightest plan of resolving this issue permanently that’s already been going on for years and is affecting not only our client’s website? Siteground usually prides themselves in trying to find permanent fixes but what you’ve told us now is ‘try to find your own fix for something that’s clearly down to our plugin and be prepared to change it constantly because we have no interest of finding a fix. Or just stop using a part of our plugin.’ Correct me if I’m wrong but that really isn’t in line with SiteGrounds quality standards?

    Plugin Author Elena Chavdarova

    (@elenachavdarova)

    Hello @roberthemsing,

    Thank you for your report and feedback.

    We have just released a new version of the plugin where the handlers mentioned in your previous thread are globally excluded from JS Combination.

    Could you please upgrade the plugin to 7.2.7 version and report back if the issue is resolved.

    Looking forward to your update.

    Best Regards,
    Elena

    Thread Starter Rosso Digital

    (@roberthemsing)

    Hi @elenachavdarova – truly appreciate you/SG doing that! Unfortunately this didn’t resolve the issue. @georgiganchev mentioned in his previous comment that the handlers probably have changed in the last 1.5yrs. Maybe different handlers have to be excluded from JS Combination now and no longer the ones that you mentioned in your reply to us back then?

    Plugin Author Elena Chavdarova

    (@elenachavdarova)

    Hello @roberthemsing,

    Indeed the handlers were changed. I managed to setup a local site with Square and found that ‘wc-square’ handler should be excluded both from JS combination and Defer Render-blocking JavaScript options.

    We will include global exclude in the future plugin releases.

    Until then it would be really helpfull if you could test the case on your end and confirm that as well.

    For the case you can use two filters: sgo_js_async_exclude and sgo_javascript_combine_exclude.

    Here is the code:

    add_filter( 'sgo_js_async_exclude', 'js_async_exclude' );
    	function js_async_exclude( $exclude_list ) {
    		$exclude_list[] = 'wc-square';
    		return $exclude_list;
    	}
    
    add_filter( 'sgo_javascript_combine_exclude', 'js_combine_exclude' );
    	function js_combine_exclude( $exclude_list ) {
    		$exclude_list[] = 'wc-square';
    		return $exclude_list;
    	}

    We are looking forward to hear from you.

    Best Regards,
    Elena

    Plugin Author Elena Chavdarova

    (@elenachavdarova)

    We have just released new version of the plugin including default exclusion of the above mentioned handler.

    Could you please update the SiteGround Optimizer plugin and report back if the issue is resolved.

    Thank you!

    Best Regards,
    Elena

    Thread Starter Rosso Digital

    (@roberthemsing)

    @elenachavdarova that did the trick! Thank you so much! Truly appreciate it especially rolling this out for everyone with a plugin update so quickly. Will the team keep an eye on the handlers in case they change again?

    Plugin Author Elena Chavdarova

    (@elenachavdarova)

    You are most welcome, @roberthemsing!

    There are many third party plugins handlers and styles we are excluding by default in the plugin. As most of them are widely used we aim to keep supporting them as much as possible.

    Still our and other plugins are constantly changing, adding new features and improving their functionalities, releasing constant updates. So there is a chance for us to miss an incompatability. For the case we follow all reports here and in our internal support channels.

    Best Regards,
    Elena

    Thread Starter Rosso Digital

    (@roberthemsing)

    Thanks @elenachavdarova !

Viewing 9 replies - 1 through 9 (of 9 total)
  • The topic ‘WooCommerce Square Checkout Conflict’ is closed to new replies.