WordPress 5.6 JS errors
-
After upgrading my website to WordPress 5.6, Popup Maker is no longer working. I’m running the latest version 1.13.1. Here is the Javascript error from DevTools that I’m seeing on my home page.
pum-site-scripts.js?defer&generated=1606139499&ver=1.13.1:7 Uncaught TypeError: t.addClass(...).position(...).trigger is not a function at n.fn.init.reposition (pum-site-scripts.js?defer&generated=1606139499&ver=1.13.1:7) at n.fn.init.p.fn.popmake (pum-site-scripts.js?defer&generated=1606139499&ver=1.13.1:7) at n.fn.init.open (pum-site-scripts.js?defer&generated=1606139499&ver=1.13.1:7) at n.fn.init.p.fn.popmake (pum-site-scripts.js?defer&generated=1606139499&ver=1.13.1:7) at pum-site-scripts.js?defer&generated=1606139499&ver=1.13.1:7
-
@moneill – At this point going backward isn’t advisable. And for clarity, if upgrading WP is the trigger point, it doesn’t mean its the cause.
It could be 3rd party plugin X happens to break when WP 5.6 is enabled, but you normally wouldn’t notice cause its a lightly used feature in JavaScript throwing errors now.
But since our popups rely on JS, that issue becomes very apparent as you now see the issue (via our popups not working).
So sometimes sites have issues there all along and only when the circumstances are just right do you see any symptoms.
The 2 guides above should help reduce the noise, narrow or even find the external factor we are missing.
Hi @danieliser,
It did allow them up until this moment.
The corect CSS is popmake-4091, and as such it cannot be opened, the prefix of # before the popmakes name was used to open them. I have the appropriate screenshots of them if it proves beneficial to you for resolving the issue.On the other hand, if said issue cannot be resolved on your end, where can I turn in order to find a solution for this problem?
Kind regards
Hi, Everyone.
Posting quickly in case this helps someone else. Setting my popup to draft and publishing it again has solved my issue.:-) They are working again as before the WP5.6 update.
Thanks i tried but not working
I had the same issue. I used the Health Check plugin to troubleshoot and it showed that the conflict is with WP-Optimize. I’ve deactivated WP-Optimize for now and the popups are working fine.
@kokicot1994 – Just from looking at your site I would first suggest your issue is completely unrelated to this thread and that you should probably open up a separate ticket with us directly at https://wppopupmaker.com/support/.
—
@mmazziotti, @racheliza – Based on those solutions I’d say something has either deleted our JS/CSS assets or corrupted them. Resaving would regenerate them.
Further an optimization plugin shouldn’t have issue unless it loads things out of order. Because we bundle our CSS/JS into a single file by default our own assets don’t tend to cause trouble with optimizers, with that exception since we require a few things like jQuery and jQuery UI to be loaded first.
—
@saltun – If you are indeed getting the same error as the original poster, I’d suggest re-reading my first 2 replies. That is a common issue that is unrelated to WP 5.6. That said it 100% indicates that your site is not loading a copy of jQuery or worse, loading 2 copies because
.trigger
has been a function in jQuery for over a decade and still is.pum-site-scripts.js?defer&generated=1606139499&ver=1.13.1:7 Uncaught TypeError: t.addClass(...).position(...).trigger is not a function
Otherwise if your seeing a different variation you may want to open your own ticket with us.
-
This reply was modified 4 years, 3 months ago by
Daniel Iser.
-
This reply was modified 4 years, 3 months ago by
Daniel Iser.
Hi, I am looking at this thread because updating to WP 5.6 caused an issue with my School’s website such that I had to restore back to the previous version of WP 5.5. We have implemented a popup on the home page of our website (https://www.carlosrosario.org/). When I upgraded to WP 5.6, the homepage never completed loading and none of the menu items or hyperlinks worked, let alone responded. When I deactivated the Popup Maker plugin, the site worked flawlessly with the 5.6 upgrade.
I’m not versed enough to dig into the JS code, etc. so absent some direction, I will need to look at replacing this plugin with another one. Thanks!
@techdirect – Try the steps in this guide and let me know. That said how many popups do you have in total? And are they all using proper targeting rules? If you have a lot of popups and no targeting rules, they could all be loading on your sites footer. That said there would be no difference in that from WP 5.5 -> 5.6 so it seems unrelated.
https://www.ads-software.com/support/topic/wordpress-5-6-js-errors/page/2/#post-13773551
Dear @danieliser
I checked with the plugin author of “WP Photo Album Plus”.
This is his response:
Jacob N. Breetvelt wrote:
Maybe this info helps:
– WPPA uses jQuery().dialog().
– These are the wp supplied js files that wppa loads:
// The js dependancies
$js_depts = array( 'jquery',
'jquery-form',
'jquery-masonry',
'jquery-ui-dialog',
);– There are no recent changes herein
-
This reply was modified 4 years, 3 months ago by
Michael.
…as I found no other dependencies in relation to Popup Maker, I can only further wait what will be happening…
Best regards
Michael
@danieliser: New development. The app has now stopped working completely. Originally it was just not loading on the homepage, and now it’s not working at all. I even deleted the pop-up and recreated it to see if was an error with that particular one and still having issues.
I haven’t made any changes of coding or anything to the website. This has been the only changes made.
I’ll review the notes you’ve given @techdirect but uncertain why the plug-in stopped working all together since I’ve done no other edits/changes to the site.
After the WP update, an auto pop up using the lightbox theme wouldn’t work on the checkout page in WooCommerce, Storefront theme. Infact only half the checkout page would show. Deactivating plugins etc., made no difference. Health Check never spotted any errors.
In the end the only solution I could find was to recreate each popup manually. Once I had done this and replaced the existing popups that didn’t work, with these newly created ones they worked fine.
Same settings, everything was a duplicate in this newly created popups. I have no idea why they now work, but this was the only solution that worked for me.
In case it helps others, I had a similar problem after Upgrading to WP 5.6. The issue wasn’t with Popup Maker but with another plugin. Simply:
1. Install and activate the “Enable jQuery Migrate Helper” plugin.
2. If this doesn’t fix it, go to tools > jQuery Migrate and select the “legacy” version of jQuery from the dropdown.This fixed the jQuery issue and the popups worked again.
-
This reply was modified 4 years, 3 months ago by
joegestalt.
@moneill – If its not working at all I’d basically start with the normal troubleshooting guide first to rule out common issues. Feel free to open a email ticket at https://wppopupmaker.com/support/. You can include a login token so I can check things out directly if you prefer. In which case please use this plugin: https://www.ads-software.com/plugins/temporary-login-without-password/
—
@mitfi – Unfortunately I wouldn’t have the feintest clue where to start with debugging why their plugin is causing issues.
I do see they made some changes a week or so ago for WP 5.6 compatibility, though I couldn’t find exactly what those were.
It should also be noted that we can’t/shouldn’t be expected to go line by line in their plugin looking for the cause if I’m being honest. We have 600k users to support for our own code. And there is a small portion of those users, yourself included, currently saying our popups aren’t working with the latest version, most are finding, as you did, causes from 3rd party products. If we took the time to debug all of these 3rd party products code ourselves we would never be able to keep up, much less advance our own code.
Now what we can and should do in these cases is attempt to narrow where the issue is coming from, and attempt to limit the scope of the other authors search. For example if we can point to a specific theme JS file or even specific function in that file it greatly improves the chances.
I haven’t seen your site specifically though to be able to comment, but if you went through my previous post with the troubleshooting steps and found nothing of note you may need to just open a support ticket with us and them and try to get them to work with us to resolve it.
That said I do see stuff in there code that won’t work in general, might be worth pointing those things out in the mean time. For example this line was added 9 days ago, but jQuery
.off
doesn’t work with anonymous functions, so the old version of this code was better. As it is this code likely does nothing, and since they are immediately doing a.on
attaching that function again, its likely going to cause it to duplicate the render call repeatedly.'$(window).off("fullscreenchange mozfullscreenchange webkitfullscreenchange msfullscreenchange",function(){abort=true;setTimeout(function(){abort=false;render();},1000)});' .
—
@eastlight100 – Sorry to hear that, strange in deed as no data has changed, and nothing in WP 5.6 would have caused data to stop working in a way that recreating the popups would have gotten around. My only guesses would be some type of persistent caching that went awry such as Redis or Query/object caching. We have seen users claim it wasn’t working only to clear all caches, optimization plugins & cdns and it work correctly.
Glad you got it working though.
—
@joegestalt – Glad to hear you got it working. Please be sure to notify the author of the other plugin so they can properly address the issues. Otherwise when WP 5.7 comes out and officially removes all the migrate and backward compatibility layers this won’t happen again. These changes are coming, no way around them but to update and ensure compatibility.
Hi guys,
If it’s to anyone’s help, I’ve found my issue regarding the Pop Up Maker.
It clashed with my Ditty News Ticker.
Once I deactivated it, everything started working as before.I suspect an update on the ticker or the pop up maker will make them coexist in the future without any issues regarding the Pop Up Maker.
Regards
-
This reply was modified 4 years, 3 months ago by
- The topic ‘WordPress 5.6 JS errors’ is closed to new replies.