WordPress 5.6 JS errors

  • Resolved Austin Ginder

    (@austinginder)


    3 years, 11 months ago

    After upgrading my website to WordPress 5.6, Popup Maker is no longer working. I’m running the latest version 1.13.1. Here is the Javascript error from DevTools that I’m seeing on my home page.

    pum-site-scripts.js?defer&generated=1606139499&ver=1.13.1:7 Uncaught TypeError: t.addClass(...).position(...).trigger is not a function
    at n.fn.init.reposition (pum-site-scripts.js?defer&generated=1606139499&ver=1.13.1:7)
    at n.fn.init.p.fn.popmake (pum-site-scripts.js?defer&generated=1606139499&ver=1.13.1:7)
    at n.fn.init.open (pum-site-scripts.js?defer&generated=1606139499&ver=1.13.1:7)
    at n.fn.init.p.fn.popmake (pum-site-scripts.js?defer&generated=1606139499&ver=1.13.1:7)
    at pum-site-scripts.js?defer&generated=1606139499&ver=1.13.1:7
Viewing 5 replies - 46 through 50 (of 50 total)
  • Thread Starter Austin Ginder

    (@austinginder)

    I spent some time troubleshooting on the staging site, here is what I found:

    • Bug only happens when updating to WordPress 5.6.
    • Bug is a conflict with Popup Maker v1.13.1 and Search & Filter Pro v2.5.2.
    • Both plugins are up to date and running the latest versions.
    • Only happens when a popup is shown. If you’ve already dismissed then you won’t see the bug.

    As a workaround I enabled an option within Search & Filter Pro called Lazy Load JavaScript. That means Search & Filter JavaScript files are only loaded on the pages that contain search forms which helps reduce the conflict with the popups. Will start a ticket with authors of Search & Filter Pro with my findings. Just wanted to post these details in case anyone else was running into the same conflict. I’ll consider my original request solved as it doesn’t seem to be problem with Popup Maker itself.

    I contacted the developer of my site’s, the developer of my site’s theme. He told me that he is aware of the problem by doing tests. The problem is not the popup Maker plugin, is not the theme or other plugins. The problem is the update to WordPress 5.6.

    Plugin Author Daniel Iser

    (@danieliser)

    @austinginder – Good find, please report it to them as well. I will say this, if delaying their scripts from loading until after ours resolved it, it does likely indicate that the change would need to be made on their end. Most often if our code fails to run some type of error in the chain ahead of ours has occurred. It would be strange for it to not be shown as an error in the browser console though.

    @saltun – Glad to hear they are helping look into the issue as well. I will point out the planned jQuery migration over 3 versions from the old version 1.12 to a modern and still supported version, v3+. The plan was solid, they even built a plugin that switched between each planned stage of the migration.

    That said the effects each individual plugin/theme author might see from these changes might range from non-existent/minimal to complete rewrites. With 50k+ plugins on the repo alone, plus themes, there are going to be some authors that didn’t make needed changes, and there will also be some missed changes in code that isn’t often used/maintained and less thought about.

    @danieliser I submitted an issue regarding this JS error – https://github.com/PopupMaker/Popup-Maker/issues/920 – looks like it might due to an incorrect event name causing the JS error

    Plugin Author Daniel Iser

    (@danieliser)

    @pakklee – The OP & your own error are completely unrelated to events in general. It means jQuery’s .trigger function isn’t available, generally an issue coming from elsewhere.

    See: https://www.ads-software.com/support/topic/wordpress-5-6-js-errors/page/2/#post-13773551

    • This reply was modified 3 years, 11 months ago by Daniel Iser.
Viewing 5 replies - 46 through 50 (of 50 total)
  • The topic ‘WordPress 5.6 JS errors’ is closed to new replies.