• Resolved frenchomatic

    (@frenchomatic)


    Are you supporting

    <amp-youtube width="1280"
      height="720"
      layout="responsive"
      data-videoid="xxxxx">
    </amp-youtube>

    In other words, two versions back I needed to add the script in the head myself

    <script async custom-element="amp-youtube" src="https://cdn.ampproject.org/v0/amp-youtube-0.1.js"></script>

    then I didn’t in the last two versions, and now I do.

    Can we be clear about whether AMP scripts get added automatically or not.

Viewing 1 replies (of 1 total)
  • Thread Starter frenchomatic

    (@frenchomatic)

    Basically a decision is needed that if somebody uses standard amp functionality in the custom editor or in the normal editor under AMP takeover – do the head scripts get added automatically.

    It seems you do conversions once again for iframes and these render in either type of editor but the specific amp iframe and the specific youtube scripts have been removed and these need to be added to the head manually. Each new upgrade brings a different protocol.

    Basically stick to one protocol – either yes scripts get added to the head or no they don’t but changing between versions makes chaos.

    I think you are at the point of having two plugins – an AMP takeover plugin which is actually about building AMP sites from the ground up or mixed sites where you are trying to support an existing canonical site and giving it an AMP version.

    Trying to do both with one plugin causes most of the issues.

    • This reply was modified 6 years, 9 months ago by frenchomatic.
Viewing 1 replies (of 1 total)
  • The topic ‘Does this script get installed automatically?’ is closed to new replies.