WP Alchemy library

  • Hi,

    In our project we are using different plugins that include same file which contains class WPAlchemy_MetaBox along with other constants and actions. Problem is that you have modified original file and still labeled it as original. 

    //add_action('admin_head', array('WPAlchemy_MetaBox', '_global_head'));
//add_action('admin_footer', array('WPAlchemy_MetaBox', '_global_foot'));
    if (!isset($arr['skip_admin_head']) || $arr['skip_admin_head'] == false) {
            add_action('admin_head', array($this, '_global_head'));
        }
        add_action('admin_footer', array($this, '_global_foot'));

    Those parts are not in the original. Maybe it doesn’t have significant impact but it’s still not the same, including your version of file might break another one who naively thinks it’s the original (as in our case).

    Another issue is that you are using tabs instead of spaces in that file (I didn’t look others). So basically comparing original file with yours looks completely different. Anyway, it’s not good practice to put tabs.

    https://www.ads-software.com/plugins/easy-pricing-tables/

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author davidhme

    (@davidhme)

    Thanks Vladan!

    I’ve noted your concerns.

    So is our version of WPAlchemy breaking anything on your end?

    We’ve modified WPAlchemy because we had various issues, please refer to this pull request which I think wasn’t approved:
    https://github.com/farinspace/wpalchemy/pull/82

    -David

    Thread Starter vladan.me

    (@vladanme)

    Thanks for swift reply.

    It is breaking in some complicate way which I can’t really explain in one post. It seems that your pull request was partially applied but that part with actions isn’t.

    Still, I agree with your approach as it is trying to resolve conflicts between multiple includes of this same script. Another issue that exists is conflict with defined constants, i.e. if file is included twice, not only it will get those actions it will also have notices about trying to redefine already defined constant for each of those. I will try to put another pull request trying to resolve this issue too once I am done with it.

    Plugin Author davidhme

    (@davidhme)

    Hi Vladan,
    That would be great. Could you post here again once you post the pull request?

    We might move away from WPAlchemy at some point and release a completely new & improved GUI, but that’s probably at least a few months out.

    Thank you,
    David

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘WP Alchemy library’ is closed to new replies.