wp_postmea filling up with _kgflashmediaplayer*

Yeah, that definitely shouldn’t happen. Certainly not on images. I’ll look in to it. I’m surprised nobody’s ever noticed it before. It’ll be a good opportunity to convert most of those meta entries to a single one. I’m a little bit hindered by my bad coding practices from when I started the project. A number of users have customized templates over the years that access some specific meta values and I don’t want to break their templates, but the ones you mentioned don’t need their own entries.

I just had a look through my own databases and I can’t find any instance of those meta values being associated with images. Only videos. Do you see the plugin fields like thumbnail generating buttons and video embed dimensions when you’re looking at images in the media library? They should only appear for videos.

No, those fields only appear for videos. I also tried to figure out where those meta values get written but couldn’t find out yet where all of it happens. But it happens.

I think it’s because the uploaded images don’t have a parent post.

I could fix most meta value entries by changing the following (line 4073):

function kgvid_image_attachment_fields_to_edit($form_fields, $post) {
   $options = kgvid_get_options();
   if ( substr($post->post_mime_type, 0, 5) == 'video'	&& (empty($post->post_parent)
       || (strpos(get_post_mime_type( $post->post_parent ), 'video') === false && get_post_meta($post->ID, '_kgflashmediaplayer-externalurl', true) == false))

Tha last part of the if Statement evaluates to true using only ==. Using === seems to fix it, except for one meta value: “_kgflashmediaplayer-forcefirst”. I guess this is because of a similiar bug.

Ok, I see why forcefirst is being set. This is some of the oldest code still in the plugin. The quick fix would be change line 4685 to
else { delete_post_meta($post['ID'], '_kgflashmediaplayer-forcefirst'); }

I don’t know why that == is evaluating to true, but it obviously doesn’t hurt to change it to ===. I tested on a couple different sites and even with an image with no parents I didn’t get any of those meta fields.

get_post_meta($post->ID, '_kgflashmediaplayer-externalurl', true) returns an empty string if that meta value hasn’t been set. And '' == false evaluates to true. Isn’t PHP nice…

I’ll test if I can reproduce the error with another setup.

Woah! I thought get_post_meta returned false if there was no entry. The codex clearly says I was wrong. I’m sure there are a bunch of times that I made that assumption. Thank you so much for doing this careful work.

Ok, I just tested with another installation, and it happens there too. And it does happen with any image, not only those without parent, as soon as I edit an attachment and click update.

Could be a red herring, and I think you’ve already solved most of the problems, but what screen are you in where you click update after editing an attachment? All the attachment editing I know about saves automatically without pressing any buttons.

It’s the edit media screen (post.php?action=edit) for editing a single attachment (the “Edit more details” link if you are using the grid view). As soon as I click on Update in the save box the meta values appear in the data base. Update returns to the edit screen.

Thank you! I was testing in the newer modal windows. I can replicate it now.