Forum Replies Created

Viewing 15 replies - 91 through 105 (of 170 total)
  • Thread Starter Aldo

    (@ab_lu)

    Thanks for the reply!
    I’ll end up removing the code in soil manually.

    Thread Starter Aldo

    (@ab_lu)

    Just got a feedback from the Soil developers:

    Soil is adding a filter onto the built-in wp_calculate_image_srcset. It’s pretty bad for a plugin to remove that filter itself which responsify is doing.

    Is there any way as mentioned in the post before to just disable the filter if RWP is activated?

    Thread Starter Aldo

    (@ab_lu)

    Yeah, I though so ??

    Regarding the issue with soil.
    I also checked the code and there is the filter who makes the replacement.
    Is there a way to disable the filter if RWP is active?

    add_filter('wp_calculate_image_srcset', function ($sources) {
      foreach ($sources as $source => $src) {
        $sources[$source]['url'] = \Roots\Soil\Utils\root_relative_url($src['url']);
      }
      return $sources;
    });

    Thread Starter Aldo

    (@ab_lu)

    Thanks for your feedback ??
    I’l stay with RWP and check with the Soil Plugin devs for a resolution.

    One last question.
    Do you know of a guide for a best approach in determining all the needed image sizes for a site?

    Thread Starter Aldo

    (@ab_lu)

    Thanks a lot for the feedback!
    What are the main differences from your plugin and the native responsive images solution apparat from the backend interface?

    @jeremy, thanks for your quick reply! Just sent an email to support.
    Cheers!

    Exactly the same problem here as well.
    How can we solve the issue?

    Thread Starter Aldo

    (@ab_lu)

    Im’ using safari, but will test in in Chrome as well.
    I’ll get back to you.

    Thread Starter Aldo

    (@ab_lu)

    Hi Stefan,
    Sorry for my late reply!

    Retina images are loaded perfectly!

    I found an issue when creating a new custom media query via the UI: When I set a rule and select “size is”, this value is not stored after the first save of the media query. I have to select it again and save the media query again, then it remains there.

    Another issue in the UI:
    If I delete a breakpoint in a custom media query, then hit save and want to add a new breakpoint after that, I get a JS error when hitting “Add”:
    addMediaQueryresponsify-wp.js:97
    TypeError: this.model.get(‘breakpoints’).push is not a function. (In ‘this.model.get(‘breakpoints’).push’, ‘this.model.get(‘breakpoints’).push’ is undefined)

    And a last question:
    I use to return a picture element:

    $rwp_attributes = array(
    			'retina' => true,
    			'attributes' => array(
    				'img' => array(
    					'class' => 'lazyload img-responsive',
    					'alt' => ''
    				)
    			)
    );
    echo Picture::create( 'element', $img_arr["ID"], $rwp_attributes );

    As you can see I do not set any sizes, as I assume setting them in the custom media query UI they are set automatically. But then I get all activated images sizes instead only the ones used in the breakpoints.
    I guess I’m wrong with the assumption. Would it not be great, if the would be set automatically according the selected sizes in the breakpoints?

    BTW: I’m using the latest version 1.9.3 of the plugin.

    Cheers,
    Aldo

    Thread Starter Aldo

    (@ab_lu)

    Yes, but I like the query settings in the interface and the possibilities to define them! ??
    Did you find something regarding the retina issue?

    Thread Starter Aldo

    (@ab_lu)

    Hi Stefan

    It is activated.
    But I had to manually add a breakpoint with the retina image size at the same breakpoint has the normal image size.

    Bug?

    Thanks
    Aldo

    Thread Starter Aldo

    (@ab_lu)

    Hi Stefan

    Thanks a lot! So far all fine now ??
    I managed setting it up using the “Use when …” image size…
    The issue now is, retina images are not set. Do I need to add them manually in the media query settings?

    Thanks
    Aldo

    Thread Starter Aldo

    (@ab_lu)

    Hi Stefan

    This are the sizes:
    large-image
    medium-image
    small-image

    Thanks
    Aldo

    Thread Starter Aldo

    (@ab_lu)

    Ok, I’m glad we figured this out ??

    But I’m still just not so familiar with the handling of the custom media queries interface.
    Could you help me out here? I would like to have a setting for the home page only.
    Right now the plugin outputs this:

    <picture ><!--[if IE 9]><video style="display: none;"><![endif]--><source data-srcset="/wp-content/uploads/2015/06/blog-24.06.15.jpg" media="(min-width: 700px)"><source data-srcset="/wp-content/uploads/2015/06/blog-24.06.15-700x531.jpg, /wp-content/uploads/2015/06/blog-24.06.15-1400x1063.jpg 2x" media="(min-width: 350px)"><source data-srcset="/wp-content/uploads/2015/06/blog-24.06.15-350x266.jpg, /wp-content/uploads/2015/06/blog-24.06.15-700x531.jpg 2x" media="(min-width: 175px)"><source data-srcset="/wp-content/uploads/2015/06/blog-24.06.15-175x133.jpg, /wp-content/uploads/2015/06/blog-24.06.15-350x266.jpg 2x" media="(min-width: 117px)"><!--[if IE 9]></video><![endif]--><img data-srcset="/wp-content/uploads/2015/06/blog-24.06.15-117x89.jpg, /wp-content/uploads/2015/06/blog-24.06.15-234x178.jpg 2x" class="size-large-image wp-image-8307 img-responsive lazyload" alt="Links Webseite 1.0 (2005-2015) / rechts Webseite 2.0 ab 2015" width="700" height="531"></picture>

    What I need is this (just the same without the first “source” instance:

    <picture ><!--[if IE 9]><video style="display: none;"><![endif]--><source data-srcset="/wp-content/uploads/2015/06/blog-24.06.15-700x531.jpg, /wp-content/uploads/2015/06/blog-24.06.15-1400x1063.jpg 2x" media="(min-width: 350px)"><source data-srcset="/wp-content/uploads/2015/06/blog-24.06.15-350x266.jpg, /wp-content/uploads/2015/06/blog-24.06.15-700x531.jpg 2x" media="(min-width: 175px)"><source data-srcset="/wp-content/uploads/2015/06/blog-24.06.15-175x133.jpg, /wp-content/uploads/2015/06/blog-24.06.15-350x266.jpg 2x" media="(min-width: 117px)"><!--[if IE 9]></video><![endif]--><img data-srcset="/wp-content/uploads/2015/06/blog-24.06.15-117x89.jpg, /wp-content/uploads/2015/06/blog-24.06.15-234x178.jpg 2x" class="size-large-image wp-image-8307 img-responsive lazyload" alt="Links Webseite 1.0 (2005-2015) / rechts Webseite 2.0 ab 2015" width="700" height="531"></picture>

    Thanks
    Aldo

    Thread Starter Aldo

    (@ab_lu)

    I cannot do it because there is no checkbox to disable. I have all the sizes but the “full”.

Viewing 15 replies - 91 through 105 (of 170 total)