adamh007

I haven’t installed / reviewed the code, but this approach is fine.

I’m not sure I understand your concern re slowing down the plugin, as the performance of the settings page is largely irrelevant, and after the images are converted the plugin doesn’t actually do anything (apart from redirecting the GET to the webp version based on header).

One thing I’d like to ask for though is to display what values the plugin is currently using on the slider – debugging WP is super awkward and functions.php is sometimes overwritten by themes (without telling me so). If you don’t display what values the plugin is using, I can never be sure if my settings were taken into account.

If you display the values on the slider, it would help users to verify their settings are working as expected.

Cheers

ps.: if this goes live, please document this on the plugin’s page – plugins without docs are so hard to work with ??

• This reply was modified 7 months, 1 week ago by adamh007.

I appreciate and agree with all of the above, but our conclusions are different: allowing to override the suggested defaults is important.

What solution do you propose

Complete solution

On the advanced tab, add a manual quality setting (numerical input box).

If you enter a value there, it would override the selector on the first tab, and the slider would display a “Custom” tab on the leftmost position.

The “Custom” tab is important as in other places (e.g., Media Library conversion dropdown) currently displays the same values as the slider. If someone enters a manual value in the advanced tab, these dropdowns would show a “Custom” item as well.

If not too hard work, the slider and the dropdown label would include the actual quality settings. This would help both current and future more technical people to understand what is “Lossy” (75), and what “Custom (50)” is when they entered the value in the Advanced tab.

Complete solution v2

As above, but add an “Advanced” checkbox next to the slider on the settings page, which turns it into a 10-99 numerical slider for anyone to set any values easily.

MVP

Add a num input on the advanced tab, which would override the slider value directly in the stored settings. This would work for batch convert and upload, but would not work for individual images in the media library.

• This reply was modified 7 months, 1 week ago by adamh007.

I don’t want to sound ungrateful, but I’m a little bit puzzled by your response.

• I did not say they do not lose quality – by definition, they do. It just doesn’t matter to the average visitor.

• Is it possible you have not tried yourself to compress typical images (illustrations) that often appear on websites with lower quality images?
• I’m not asking to optimise the plugin for a sample of my specific image.

Instead, I’m asking not to hardcode an arbitrary value of 75 as the lowest quality setting, as this may be a correct choice for some, but incorrect for others. It might be easy for you to agree with that it is not up to plugin authors to decide what settings people should use on their websites.

In any case, here is a typical sample illustration with the original 80-90 (284kb), 50 (154kb), and 25 (100kb) quality settings. I would be happy to put any of them on my site, especially for mobile users.

Filebin | iudptq82ldwoyhs9

The link expires in 6 days.