Andrea Fercia

Hi there. Cool, thanks.

@janellucia, aria-label on the UL or LI wouldn’t work because they’re not focusable elements. Instead, I’d recommend to address better accessibility at a theme level”
– wrap the navigation menu in a <nav> element
– a <nav> element is already announced as “navigation” by screen readers and it is a landmark region
– only if you need to distinguish two (or more) different navigation menus, add aria-label attributes to the nav elements
– see for example what Twenty Seventeen does

Thanks very much Kathryn ??

hi,
themes can set a specific size for the thumbnail image and TwentyFourteen sets is to: width 672 pixels, height 372 pixels, with the “crop” parameter set to “true”.
That means it will try to resize *and* crop the thumbnail images to that exact size.
Keep in mind WordPress can’t *upscale* images, but just downsize them.
Now, your original image is 2374 x 897 pixels, bigger than the thumbnail size so WordPress is able to resize and crop it to exactly 672×372.
You have 2 options:

1)
start from an original image with same ratio or multiple of 672×372, for example: 1344×744 and so on and for doing this you will have to add “white space” on top and bottom of your image.

or:

2)
start from an image with an height less than 372 pixels. The interesting part here is WordPress can’t upscale images so, for example, if you start with an image of 800×302 WordPress will be able to reduce the width but it won’t increase the height. The result will be a thumbnail image of 672×302.
I fear also in this case you will need to add a bit of “white space” on top and bottom of your original image because its ratio is very “stretched” horizontally compared to the thumbnail ratio (672×372)

I already updated. Running version 1.1.0 right now.
I can manually fix the function name of course but please check your 404.php file, it’s all it takes, simple right?
You will see all versions have the wrong function name:
https://themes.svn.www.ads-software.com/sparkling/1.1.0/404.php
https://themes.svn.www.ads-software.com/sparkling/1.0.4/404.php
https://themes.svn.www.ads-software.com/sparkling/1.0.3/404.php
https://themes.svn.www.ads-software.com/sparkling/1.0.2/404.php
https://themes.svn.www.ads-software.com/sparkling/1.0.1/404.php
https://themes.svn.www.ads-software.com/sparkling/1.0/404.php

oh yes sorry, it was wpmu “awesome_2014” child theme
https://premium.wpmudev.org/blog/how-to-make-twenty-fourteen-or-any-other-wp-theme-super/
that I was testing and added a bar for the get_bloginfo( ‘description’ )
sorry,
Andrea

great ?? upgraded and starred

hi, yea seems it works
but you should check how many times the match is run
it seems to me the match is run multiple times, one for each of the 12 set of regexes that’s because you have 12 provider files included, each one with its class and its $regexes
maybe I would try to build a single array of all the regexes and run the match just once

hi, thx for you reply.
Yes I know how it works, I can read code ??
That’s the whole point, currently your $regexes are compared to the $markup in the order you include the files.
First one included is the one for youtube, so if $markup has multiple embeds, let’s say first vimeo and second youtube, it will check first for youtube even if the embed is the last one. When it finds youtube, the match is done and it will stop, skipping the vimeo embed even if it’s the first one in the $markup.
This looks not correct to me, because the “featured” video should always be the first one that editors put in the markup.
Maybe you could try with PREG_OFFSET_CAPTURE and work with offsets but this would mean running all the regexes as first step then find the first offset, hence the performance concern you mentioned.
Meanwhile, you could consider to inform your users stating in your documentation that currently it correctly works just if you have one embed per post.
Btw I really appreciate the effort you made to have so many providers ??
Thx, regards
Andrea

thx Kov for your work and congratulations for your first WordCamp Russia ??
As far as I know this is a IE8 bug, you can find details at Using max-width on images can make them disappear in IE8

@no1se you could temporary use a css hack targeting IE8 and below:
.entry-thumbnail img {
…
max-width: 100%;
max-width: none\9; /* IE8 and below */
…
}
but it would be definitely better to include a specific IE8 css with conditional comments.
Greetings from Italy

thx Mike,
I noticed also the “skip_install_woocommerce_pages” option doesn’t get deleted when you uninstall, maybe you should consider to change in your uninstall.php:
$wpdb->query(“DELETE FROM $wpdb->options WHERE option_name LIKE ‘woocommerce_%’;”);
with:
$wpdb->query(“DELETE FROM $wpdb->options WHERE option_name LIKE ‘%_woocommerce_%’;”);

there are also some postmeta and some comments (used as order statuses?) you should consider to remove upon uninstallation and maybe also some capabilities assigned to admin.
A great plugin should really clean up things ??
thx
Andrea

seems there is still one <? to change in <?php at line 406
this will cause the “unexpected $end” error for servers where PHP short tags are disabled
hope Tilex will fix it ??
Andrea