alex.bradaric

Hi @vmarko

Thanks for getting back to me. That’s a step in the right direction – it doesn’t break the page any more.

However, there’s still the issue of the post ID for Purge Current Page menu item – your fix does not detect it correctly ( see the screenshot: https://staging.undercurrentnews.com/img/w3tc-0-post-id.png )

Thanks again ??

Take care,
Alex

Hi Marko,

Here are the screenshots without the fix ( https://staging.undercurrentnews.com/img/w3tc-without-fix.png ) and with the fix ( https://staging.undercurrentnews.com/img/w3tc-with-fix.png )

I’ve also reverted the fix I made here: https://staging.undercurrentnews.com/2017/11/17/scottish-salmon-prices-continue-rebound-norwegian-fall-back-to-two-year-low/

It breaks the page and does not finish loading it (including the admin bar).

Take care,
Alex

Hi,

Here’s the .diff of what I’ve settled on for our site – would be nice to see something similar (I’m fine with it not using non_wp_rules too ?? in one of the future releases.

diff -r -w oauth2-provider-3.1.7/includes/rewrites.php oauth2-provider/includes/rewrites.php
17,23c17,23
<     function create_rewrite_rules($rules) {
<         global $wp_rewrite;
<         $newRule = array('oauth/(.+)' => 'index.php?oauth=' . $wp_rewrite->preg_index( 1 ) );
<         $newRule += array('.well-known/(.+)' => 'index.php?well-known=' . $wp_rewrite->preg_index( 1 ) );
<         $newRule += array('wpoauthincludes/(.+)' => 'index.php?wpoauthincludes=' . $wp_rewrite->preg_index( 1 ) );
<         $newRules = $newRule + $rules;
<         return $newRules;
---
>     function create_rewrite_rules($wp_rewrite) {
>         if (!defined('DEACTIVATING_OAUTH2_PROVIDER') || !DEACTIVATING_OAUTH2_PROVIDER) {
>             $newRule = array('oauth/(.+)' => 'index.php?oauth=$1' );
>             $newRule += array('.well-known/(.+)' => 'index.php?well-known=$1' );
>             $newRule += array('wpoauthincludes/(.+)' => 'index.php?wpoauthincludes=$1' );
>             $wp_rewrite->non_wp_rules = array_merge($newRule, $wp_rewrite->non_wp_rules);
>         }
74c74,75
< add_filter( 'rewrite_rules_array' , array($WO_Rewrites, 'create_rewrite_rules' ));
---
>
> add_action( 'generate_rewrite_rules', array($WO_Rewrites, 'create_rewrite_rules'));
76d76
< add_filter( 'wp_loaded' , array($WO_Rewrites, 'flush_rewrite_rules'));
diff -r -w oauth2-provider-3.1.7/wp-oauth.php oauth2-provider/wp-oauth.php
54a55
> register_deactivation_hook(__FILE__, 'wo_plugin_deactivate');
70a72,75
>
>     $wo_rw = new WO_Rewrites;
>     $wo_rw->create_rewrite_rules();
>     $wo_rw->flush_rewrite_rules();
73a79,85
> function wo_plugin_deactivate() {
>     if (!defined('DEACTIVATING_OAUTH2_PROVIDER')) {
>         define('DEACTIVATING_OAUTH2_PROVIDER', true);
>     }
>     global $wp_rewrite;
>     $wp_rewrite->flush_rules();
> }

Thanks ??

Take care,
Alex

Hi Justin,

Thanks for the reply.

Not sure a list of plugins will help as it’s a lengthy one:
—
BAW Manual Related Posts
Category Order and Taxonomy Terms Order
Chartbeat
Co-Authors Plus
Google Analytics by Yoast
Google Analytics Dashboard
Insert Pages
Intercom for WordPress
Liveblog
NextGEN Gallery by Photocrati
NextGEN Gallery Sidebar Widget
NextGEN Pro by Photocrati
Optimize Database after Deleting Revisions
Post Date Change Redirection
Post Types Order
Recently Registered
Regenerate Thumbnails
Related Posts Thumbnails
Rename wp-login.php (unmaintained)
Reports Plugin
RSS Icon Widget
s2Member Framework
Search & Filter
Send email only on Reply to My Comment
Sharing Tracker
TablePress
UCN newsletter builder
WordPress OAuth Server
WP Currency Converter
WP REST API
WPJobBoard
—

And for what it’s worth, I wouldn’t keep it running on wp_load. No offence, but too many plugins keep too much stuff running on init and wp_load just because they can’t be bothered to find a suitable place for it ??

I’ll keep that wp_load hook disabled and have the rewrite rules added to .htaccess (via non_wp_rules) for the time being.

Hope you can figure it out though. Thanks ??

Take care,
Alex

Hi,

See here for a workaround: https://www.ads-software.com/support/topic/error-gathering-analytics-data-from-google-1

Take care,
Alex

Hi,

It seems all you have to do is replace all occurrences (3 at the moment) of:
$consumer = new GADOAuthConsumer('anonymous', 'anonymous', NULL);
with:
$consumer = new GADOAuthConsumer('YOUR OAUTH CLIENT ID', 'YOUR OAUTH CLIENT SECRET', NULL);
in the plugin code and go through the login procedure again (Settings > Google Analytics Dashboard).

The only downside is that you’ll have to be careful when WP updates the plugin as it will overwrite your changes… Would be nice if there was an option to provide Client ID/Client Secret in the UI instead or editing the code ??

Take care,
Alex

Hi,

Have you managed to sort this out? If yes, could you tell me how? Thanks ??

Take care,
Alex