alexp11223
Forum Replies Created
-
Forum: Plugins
In reply to: [Ship Estimate for WooCommerce] Error logs with Paypal Payment plugin@rermis I don’t use this plugin (but it seems to work fine with the PayPal plugin, at least with the default settings), I am one of the developers of the PayPal plugin and I was just wondering if you can provide more details about the “domino effect” you mentioned, or if you were simply referring to the fact that the log contains other errors involving the PayPal plugin.
Forum: Plugins
In reply to: [Ship Estimate for WooCommerce] Error logs with Paypal Payment plugin@rermis Hi, can you elaborate about the effect created by the PayPal plugin? Were you able to reproduce some issue when using your plugin together with it or do you mean that the first errors in the stack trace above is from the PayPal plugin?
It seems to me that these two issues are not related, and they were logged at different time. The error says that the
WC()->session
field contains some strange object instead of the WC session object. Maybe it was a conflict with some other plugin.Yeah, it is possible to fix it via filter, but still it is a bug in your plugin, are you planning to fix it?
Most likely it is just an accidentally copied css class (e.g. from the ToS checkbox code) here, because as I explained earlier I don’t see any reason for this checkbox to have this validation class.
Sure, but it’s still a bug in your plugin that you should fix. It makes no sense to mark this element as a required field. It is not a checkbox that supposed to be required like Terms of Service etc.
About the PayPal plugin mentioned above (the official WC plugin), to reproduce you can install 1.9.0 pre-release package, activate it in the settings with any PayPal sandbox or real account, enable the consent checkbox in your plugin, and then during checkout when clicking the PayPal button you will get an error about required fields not being filled if the consent checkbox is not checked.
Themes affect how it looks, so in TwentyTwo it’s red text instead of red border, which I guess was not intended too.
To reproduce this, it’s enough to install and activate your plugin, enable the consent checkbox, and click it twice during checkout.
UPD: oh, it was in WC 6.0, after updating to 6.6 the styling of invalid inputs disappeared in this theme. But still reproducible in Storefront, the official WC theme.
- This reply was modified 2 years, 5 months ago by alexp11223.