Andi Lee Davis

Or in

/email-subscribers/lite/includes/libraries/action-scheduler/classes/data-stores/ActionScheduler_wpPostStore.php

protected function create_post_array( ActionScheduler_Action $action, DateTime $scheduled_date = NULL ) {
$post = array(
‘post_type’ => self::POST_TYPE,
‘post_title’ => $action->get_hook(),
‘post_content’ => json_encode($action->get_args()),
‘post_status’ => ( $action->is_finished() ? ‘publish’ : ‘pending’ ),
‘post_date_gmt’ => $this->get_scheduled_date_string( $action, $scheduled_date ),
‘post_date’ => $this->get_scheduled_date_string_local( $action, $scheduled_date ),
);
return $post;
}`

`

There does not seem to be any filter for the POST TYPE, The self::POST_TYPE is set to
const POST_TYPE = ‘scheduled-action’; presumably this gets set before the method is accessed?

I think the issue is in this line:

/lite/includes/db/class-es-db-campaigns.php
Lines 686,687

$post_type = ES_Common::prepare_custom_post_type_string( $post_type );
				$where    .= " and categories LIKE '%" . wp_specialchars_decode( addslashes( $post_type ) ) . "%'";

Should it not be where posts->post_type = xyz
As this is about getting the post by post_type not by category?

Hi there,

We have notification from Stripe that the plugin is out of date although your message did say that we did not have to do anything as that Stripe would handle this automatically through Radar, are you able to confirm what needs to be done in order to keep the integration?

Thanks

Andi

Thanks

Ok so to confirm that before you had them amalgamated and decided to remove that option.

Thanks

Andi

Nice one!

I’m sure the developers will get to look at this post and find a fix in due course.

Thanks

Andi

You might need an onchange or onsubmit event to wrap around this, however have a look and see if there are any hooks or JS hooks regarding WooCommerce or the plugin has any specific.

https://docs.woocommerce.com/wc-apidocs/class-WC_Checkout.html
https://docs.woocommerce.com/document/composite-products/composite-products-js-api-reference/

Something like an php hook to send back to php and return a value to process the js from submitting the form or in the js itself might have a function.

I know Ninja Forms uses Backbone and Marionette listeners for the forms so you can interrupt processing there.

I remember having to hack the plugin itself because the JS added extra digits to the year. In assets/js/front-end/main.js (note you will need to re minify this.

You will find lines like this line 81 – 95
Here is my version that fixes the checkout error on the date

$(document).on('change, keyup', '#' + st_object.id + '-card-expiry', function () {
		if ($(this).val().indexOf('/')) {
			///var date_details = $(this).val().split(' / ');
			var date_details = $(this).val().toString().split('/');

			if(date_details.length > 1) {				
				/// 29.01.2019 - Fixed
				$('#' + st_object.id + '-cc-month').val( date_details[0].trim() );
				///$('#' + st_object.id + '-cc-year').val( "20" + date_details[1] );
				
				$('#' + st_object.id + '-cc-year').val( date_details[1].trim() );

			}
		}
	});

Also use ‘ quotes not ‘ and ’

Looks like its missing the $ from the class selector in the jQuery.

if($(‘.payment_method_st_gateway’).is( ‘:checked’ )) {

and a closing brace to line 75

}

We gave up on this plugin after a while.
hope that helps.

ok also in this file…

classes / class-st-payment-gateway.php

in three instance around lines 531, 631, 901

$expiry_date[1] = '20' . $expiry_date[1];
the issue with this is that it expects the date input is going to be just the last 2 digits. ie 2021, 21.

my card data is saved in the rowser and returns the full date wgereas the paynent gateway mask is 2 digits or yy, however this gets overwritten and sends yyyy format.

so after i figured out that part of the issue is some lines of code prefixing 20 as in the centuary before the array part as in the class is expecting… i added this function.

public function prefix_year($date){
	    $pattern ='/^([0-9]{2})$/';
	    $date = preg_replace($pattern, '20$1', $date);
	    
	    return $date;
	}

thus function will check the length of a value and return the prefix if it is only 2 characters long, or the four digit date.

so all you have to do with those three lines is pass it to the filter method above.

///$expiry_date[1] = '20' . $expiry_date[1];
		$expiry_date[1] = $this->prefix_year($expiry_date[1]);

dont forget the js solution as well…then it all works… or should do.

thanks,

andi

Your error is here:

assets / front-end /js /main.js (main.min.js)

Line 85:

$('#' + st_object.id + '-cc-year').val( "20" + date_details[1] );

* You do not need to prefix the 20
* the 20 + string of date_details[1] which is probably an integer equates to undefined.

Solution

remove the spaces around the / and make sure it is a string

var date_details = $(this).val().toString().split('/');

Check the array length is > 1 to prevent undefined error on the second part of the array trying to populate the hidden page fields.

if(date_details.length > 1) {

remove the 20 and trim any white space so it reads…

$('#' + st_object.id + '-cc-year').val( date_details[1].trim() );

This is the whole fix in place.

$(document).on('change, keyup', '#' + st_object.id + '-card-expiry', function () {
		if ($(this).val().indexOf('/')) {
			///var date_details = $(this).val().split(' / ');
			var date_details = $(this).val().toString().split('/');

			if(date_details.length > 1) {				
				/// 29.01.2019 - Fixed
				$('#' + st_object.id + '-cc-month').val( date_details[0].trim() );
				///$('#' + st_object.id + '-cc-year').val( "20" + date_details[1] );
				
				$('#' + st_object.id + '-cc-year').val( date_details[1].trim() );

			}
		}
	});

Now this all works and checks out but the return post never updates the WC checkout so you are stuck on the same page.

Thanks

Andi

Sorry guys another one…
<br />?<b>Notice</b>: Undefined index: attach_csv in <b>/wp-content/plugins/ninja-forms/includes/Actions/Email.php</b>

Seems you might have to look at making sure you save your form submission settings etc… Or building in negation into these handlers.

Ok Found the issue.

In each form, under emails and actions > submission you need to make sure you have something selected in Designated Submitter’s Email Address, when you first install Ninja Forms this is left blank, hence there is no index on line plugins/ninja-forms/includes/Actions/Save.php on line 181 in …

$save_all_none = $action_settings[ 'fields-save-toggle' ];

Should have some sort of negation…

$save_all_none = (isset($action_settings[ 'fields-save-toggle' ]) ? $action_settings[ 'fields-save-toggle' ] : 'save_none');

further down on lines 196 looks for an else of save none…

} // Otherwise... (We were told to save no fields.)
            else if( 'save_none' == $save_all_none ) {

Hope this helps.

Hi there,

I also just started getting this error too.
I’ll also see if I can figure it out.

Thanks

Andi

Hi There,

We also have the same issue.

Thanks

Andi

Yeah we got this, the default outputs nothing but causes the error:

We have detected the following issues that affect the SEO of your site.

Your homepage cannot be indexed by search engines. This is very bad for SEO and should be fixed.

The site has no crawl errors, but I still have had a hard time trying to explain this to our client. Everytime I try to re-fetch it shows this error, whilst some websites do not have this issue.

Can you ask Ryte (formally OnPage.org) to stop reporting this on pages without metas or indexable pages as set out by your plugin.

Best Regards,

Andi