andrew666

LOL, too easy. Had a similar css ready to be pasted JUST before you answered, but I was side-tracked answering another email someone sent abut jamming carousels in mastheads ??

I didn’t know it was already patched in dev, but I should have figured you were on top of it… I was looking forward to a moment where I could jump in there and offer you something in return for all your hard work!

UPDATE: Yep.. it’s in need of a patch. It affects search pages, tags, categories, 404.. pretty much everything that has no featured image and not enough content to fill the browser window.

I fixed it! Albeit the quick and dirty way. Your plugin code was very helpful. I simply added an if/else to cover the custom podcast taxonomy. I hope this doesn’t slow down page loads. Here’s the code:

    // get the next post link
    if( has_term( '', 'series' ) ) {
    $next_post_link = get_next_post_link('%link', '<span class="btn-text">' . $next_label_text . '</span> <span class="btn-icon"><i class="fa fa-chevron-circle-right"></i></span></span>', true, '', 'series');
    }else{
    $next_post_link = get_next_post_link('%link', '<span class="btn-text">' . $next_label_text . '</span> <span class="btn-icon"><i class="fa fa-chevron-circle-right"></i></span></span>', true);
}
    
    // get the previous post link
    if( has_term( '', 'series' ) ) {
    $prev_post_link = get_previous_post_link('%link', '<span class="btn-icon"><i class="fa fa-chevron-circle-left"></i></span> <span class="btn-text">' . $prev_label_text . '</span>', true, '', 'series'); 
    }else{
    $prev_post_link = get_previous_post_link('%link', '<span class="btn-icon"><i class="fa fa-chevron-circle-left"></i></span> <span class="btn-text">' . $prev_label_text . '</span>', true); 
}

Thanks for the help! Although I don’t think it’s my place to do so, may I suggest that a future update include code to support this feature (or make it easily modifiable).. perhaps a pref that allows users to choose in_same_term and/or excluded terms? It’s such an overlooked, yet useful feature in most themes. It wouldn’t be too difficult to add a query that pulls out both builtin and custom taxonomies and tosses them into a variable for parameter placement. If I ever get the time, I can probably do it for you, but it’s probably best to let the original dev do it since everyone develops in their own way… best not to step on toes ??

I guess I didn’t mention that I was using a child theme ?? I wouldn’t dare hack any of the well thought out code you developed (well.. let’s not discuss the leftover next/prev posts code in single.php, heh).

The plugin you threw together works great for posts! Thanks! I can use it there for sure. Unfortunately, I’m using the Seriously Simple Podcasting plugin that adds some taxonomy that makes the prev/next links vanish completely on those pages. I’ll have to take a closer look tomorrow to see what might be happening. For all I know, it could just be a matter of adding some small code snippet to your plugin. If you have a chance before I do (road trip recovery is a harsh mistress), take a look at the plugin -> https://www.seriouslysimplepodcasting.com/ .. install it, make a couple posts in different “Series” and watch as the buttons vanish – magic, I tell you! ?? Alternatively, I can make you an admin account on my staging site so you don’t have to go through all the aforementioned fuss.

Cheers,
Drew